SimplePortal

Underdog · « **on:** October 01, 2011, 07:02:37 AM »

All files for both SMF versions have been updated with the proper Simple Portal version but not for the SMF version.

ie. SMF 1.1.15

Code: [Select]

/*
* Software Version:           SMF 1.1.11                                          *
*/

ie. SMF 2.0.1

Code: [Select]

/*
@version 2.0.1 
*/

In: Admin -> Form Maintenance -> Check all files against current versions

For Sources & Templates it shows as ?? for both installed and current.
Language files reflect current SP version.

[SiNaN] · « **Reply #1 on:** October 02, 2011, 07:17:13 AM »

If you mean the Detailed Version Check function in SMF not showing the version of the SimplePortal files properly, that's to be expected. We just need to make sure that our file headers are up-to-date.

Underdog · « **Reply #2 on:** October 11, 2011, 02:56:00 PM »

Version checks failed with updated SMF file headers.

.. I assume this is what I was referring to here?

Beta 3 - still pending.
An example of updated headers was given above btw.

[SiNaN] · « **Reply #4 on:** October 12, 2011, 08:44:50 AM »

There are three version checks in SP: in install2.php, PortalStandalone.php and Subs-Portal.php (SMF 2.0 version). The code looks something like this:

Code: [Select]

$data = substr(file_get_contents($forum_dir . '/index.php'), 0, 4096);
if (preg_match('~\*\s*Software\s+Version:\s+(SMF\s+.+?)[\s]{2}~i', $data, $match))
	$forum_version = $match[1];
elseif (preg_match('~\*\s@version\s+(.+)[\s]{2}~i', $data, $match))
	$forum_version = 'SMF ' . $match[1];

It is just to get the real and correct SMF version (some people hide the SMF version - no idea why they do such a thing) to make things work fine. It's not related to the Detailed Version Check feature in SMF admin area.

[SiNaN] · « **Reply #5 on:** October 17, 2011, 08:34:09 AM »

Closed this as well. Again, that's the expected behavior.

SimplePortal

Issue: Updated file versions.

Underdog

[SiNaN]

Underdog

[SiNaN]

[SiNaN]

Issue Changes

Issue Details

Tags