collapse

* Simple Portal Archived Forum

This is an Archive Forum.

The content in this forum may be out-of-date or have been superseded by newer information, and links in forum pages to other sites may not work.
This forum contains archives for future reference.

Visit our thread at Simple Machines Forum for current support.

SMF 2.1 users: EhPortal is a ported version of Simple Portal specifically designed for the SMF 2.1 branch.
Please visit web-develop.ca to download EhPortal and for its support.

* User Info

 
 
Welcome, Guest. Please login or register.

* Who's Online

  • Dot Guests: 504
  • Dot Hidden: 0
  • Dot Users: 0

There aren't any users online.

* Shoutbox

Refresh History
  • Shoutbox is not for support!
  • {OCS}MasterSeal: Yup, Still adore SP
    April 21, 2019, 07:08:06 PM
  • {OCS}MasterSeal: STILL love SP :)
    November 24, 2018, 05:05:50 AM
  • ♦ Ninja ZX-10RR ♦: <3 aegersz
    September 13, 2018, 03:36:09 PM
  • aegersz: I STILL <3 LOVE SimplePortal
    September 13, 2018, 07:11:39 AM
  • aegersz: o LOVE you guys - Simple Portal rocks !
    May 09, 2018, 05:18:59 AM
  • Chen Zhen: our apologies for the site being down.. please read server issues topic
    March 22, 2018, 05:32:38 AM
  • {OCS}MasterSeal: LOL PLEASE forget I just posted that. I found the answer in my own dang post back in 2015. lol sorry!
    July 04, 2017, 10:47:55 PM
  • {OCS}MasterSeal: I know this SB isnt' for support, but I just have a general question. Who would I contact to find out where SP stores its block info? Is it DB driven or files? I searched the site but came up with nothing. probably my fault any insight is appreciated.
    July 04, 2017, 10:43:36 PM
  • ♦ Ninja ZX-10RR ♦: Excuse me but what does Simpleportal have to deal with that?
    February 05, 2017, 08:21:14 PM
  • WhiteEagle: of course IMHO that site appears to be dead :(
    February 04, 2017, 01:08:05 PM
  • WhiteEagle: If I can get that, then I'll use it for that site...
    February 04, 2017, 01:07:35 PM
  • WhiteEagle: decided to not use SMF for any projects, unless I can get a copy of the premium version of the fanfiction archive plugin
    February 04, 2017, 01:06:54 PM
  • expertdecisions: cloudflare
    January 28, 2017, 08:01:47 AM
  • aegersz: SM release 2.0.13 !
    January 12, 2017, 06:00:13 AM
  • raffo: Tks Emanuele, even if I didn't understand the fix :D
    November 07, 2016, 02:01:20 AM
  • emanuele: [link]
    November 01, 2016, 12:43:50 PM
  • emanuele: raffo: the English support board is a good place. ;)
    November 01, 2016, 12:43:38 PM
  • raffo: Where can I find the fix for the shoutbox?
    November 01, 2016, 05:06:09 AM
  • {OCS}MasterSeal: To the SP team, I make a point to come here and thank you as much as possible for your work.  so again, THANK YOU!
    October 28, 2016, 10:38:05 AM
  • emanuele: That's indeed funny, the limit is present only in the patch and not the full install.
    October 22, 2016, 06:14:58 PM

* Recent Posts

Adding Forums Button to Nav bar by jirapon
[August 01, 2019, 09:07:12 AM]


Re: Board Icons by ♦ Ninja ZX-10RR ♦
[July 30, 2019, 04:03:41 PM]


MOVED: Czech translation???? by ♦ Ninja ZX-10RR ♦
[July 30, 2019, 03:04:51 PM]


Board Icons by jirapon
[July 30, 2019, 07:28:44 AM]


Re: Thankyou Simpleportal, by ♦ Ninja ZX-10RR ♦
[July 29, 2019, 09:41:29 AM]

Thanks for having an interest with our portal. If you have any requests for features, have a look at the Feature Requests board.

Author Topic: cutom html block problem  (Read 7590 times)

0 Members and 1 Guest are viewing this topic.

Offline pluteus

  • Semi Newbie
  • *
  • Posts: 6
  • SP Version: 2.3.3
cutom html block problem
« on: November 22, 2015, 02:08:26 PM »
i recently added a custom html block to the portal on our forum with links to facebook and twitter on it,
and am now getting this error in the logs.

8192: : The /e modifier is deprecated, use preg_replace_callback instead
Apply Filter: Only show the errors from this file
File: /var/www/html/forum/Sources/PortalBlocks.php
Line: 2028



this is line 2028 from sourced.php
   $data = preg_replace('~<\!\[CDATA\[(.+?)\]\]>~e' . ($context['utf8'] ? 'u' : ''), '\'#cdata_escape_encode#\' . $smcFunc[\'htmlspecialchars\'](\'$1\')', $data);


i have tried changing the  "preg_replace"() part with  "preg_replace_callback" instead, but this gives me a blank white page.

as you can probably tell, i well out of my depth with any php related stuff,
so can anyone tell me what i need to change to correct the error?

smf version 2.0.11
simple portal 2.3.6

Offline emanuele

  • Developer
  • *
  • Posts: 293
Re: cutom html block problem
« Reply #1 on: November 22, 2015, 04:22:26 PM »
I'm not the best person to give preg_replace answers, but it may be:
Code: [Select]
preg_replace_callback('~<\!\[CDATA\[(.+?)\]\]>~' . ($context['utf8'] ? 'u' : ''), function($matches) {
    global $smcFunc;

    return '#cdata_escape_encode#' . $smcFunc['htmlspecialchars']($matches[0]);
}, $data);

Offline Chen Zhen

  • The Underdog
  • Operations Manager
  • *
  • Posts: 1350
  • Gender: Male
  • Kinesis
    • WebDev
  • SMF Version: 2.1
  • EhPortal Version: 1.22
Re: cutom html block problem
« Reply #2 on: November 22, 2015, 04:38:04 PM »
Closures require the use language construct whereas the global will not work with what you posted there.
You need to ensure the global is called prior to executing the closure and then pass that global via the use construct.

Offline pluteus

  • Semi Newbie
  • *
  • Posts: 6
  • SP Version: 2.3.3
Re: cutom html block problem
« Reply #3 on: November 23, 2015, 04:30:52 AM »
thanks guys  :)

i have tried the code suggested by emanuele, and it seems to have done the trick, as the error logs are not showing the error anymore,
and the custom block (and the rest of the forum) is working fine  :)

i dont see any errors or problems anywhere, so i'm assuming every thing is good  :)

Offline emanuele

  • Developer
  • *
  • Posts: 293
Re: cutom html block problem
« Reply #4 on: November 23, 2015, 08:16:07 AM »
Closures require the use language construct whereas the global will not work with what you posted there.
You need to ensure the global is called prior to executing the closure and then pass that global via the use construct.

As far as I know, closures work exactly like any other function, with the addition that you can use the use construct.

So, both the one I proposed and:
Code: [Select]
preg_replace_callback('~<\!\[CDATA\[(.+?)\]\]>~' . ($context['utf8'] ? 'u' : ''), function($matches) use ($smcFunc) {
    return '#cdata_escape_encode#' . $smcFunc['htmlspecialchars']($matches[0]);
}, $data);
should work the same way. ;)

Offline Chen Zhen

  • The Underdog
  • Operations Manager
  • *
  • Posts: 1350
  • Gender: Male
  • Kinesis
    • WebDev
  • SMF Version: 2.1
  • EhPortal Version: 1.22
Re: cutom html block problem
« Reply #5 on: November 23, 2015, 08:04:34 PM »
From what is stated on php.net it says any variable needs to be passed via the use construct.
However it does not state anything about globals specifically. If it works while testing then I will assume they do hold there value.
When I applied this fix some time ago I used the latter.

ref. http://simpleportal.net/index.php?issue=471.0

Offline emanuele

  • Developer
  • *
  • Posts: 293
Re: cutom html block problem
« Reply #6 on: November 24, 2015, 08:48:48 AM »
Even though it's kind of OT:
From what is stated on php.net it says any variable needs to be passed via the use construct.
However it does not state anything about globals specifically. If it works while testing then I will assume they do hold there value.
Inheriting variables from the parent scope is not the same as using global variables. Global variables exist in the global scope, which is the same no matter what function is executing. The parent scope of a closure is the function in which the closure was declared (not necessarily the function it was called from). See the following example:
That means exactly what is written, nothing more, nothing less: "use" is not the same as "global".
The difference is that you can use "use" to "import" (from the function you are "using" the closure from) a variable into a closure. But that variable you "import" can either be a local or global, it doesn't really matter.
On the other hand, a closure it's a function, so you can use "global" to "import" a global variable into the closure scope.

Offline Chen Zhen

  • The Underdog
  • Operations Manager
  • *
  • Posts: 1350
  • Gender: Male
  • Kinesis
    • WebDev
  • SMF Version: 2.1
  • EhPortal Version: 1.22
Re: cutom html block problem
« Reply #7 on: November 24, 2015, 11:44:10 PM »

You are correct.. I read the rule above the one you just quoted and did not see that one.
Even though I looked on the page for a global reference I missed it in error.
I've been passing globals via the use construct all this time which appears to have been unnecessary.
Thanks for pointing it out.

Offline ccbtimewiz

  • Hero Member
  • *****
  • Posts: 2185
  • Gender: Male
  • $("div.content:dd").hide();
  • SMF Version: None
  • SP Version: None
  • Elkarte Version: None
  • EhPortal Version: None
Re: cutom html block problem
« Reply #8 on: November 24, 2015, 11:54:46 PM »
And at the end of the day you get more experience and everyone learns, including myself.