SimplePortal

Support => English Support => Topic started by: stikkki on December 09, 2009, 05:12:38 PM

Title: RC2 block border (tborder)
Post by: stikkki on December 09, 2009, 05:12:38 PM

SP 2.3.1
2.0RC2
http://www.eotsdzine.com/DEMO/index.php


Using core based themes SP 2.3.1. on 2.0RC2 doesnt display the tborder's around the blocks like it did on previous versions of SMF

is this intentional?

i have the portal on my SMF themes demo site as a lot people use portals wanted to show the theme with a portal installed but frankley without the tborder class on blocks it makes the theme look "broke" without the borders displayed - this can be seen on he link above

i know RC2 curve doesnt use tborder's but core based themes do and the borders dont display around the blocks which does diminish themes when used with SimplePortal

Title: Re: RC2 block border (tborder)
Post by: Nathaniel on December 10, 2009, 02:48:48 AM

There is a bug with the way that SimplePortal detects whether or not a theme is based on core, its inconsistent with the method that SMF uses.

The edit below will fix that bug.

Code: ("Find (Sources/Subs-Portal.php)") [Select]

$context['SPortal']['core_compat'] = in_array($forum_version, array('SMF 2.0 Beta 3 Public', 'SMF 2.0 Beta 3.1 Public', 'SMF 2.0 RC1', 'SMF 2.0 RC1-1', 'SMF 2.0 RC1 1', 'SMF 2.0 RC1.1', 'SMF 2.0 RC1.2'));

Code: ("Replace") [Select]

$context['SPortal']['core_compat'] = in_array($forum_version, array('SMF 2.0 Beta 3 Public', 'SMF 2.0 Beta 3.1 Public', 'SMF 2.0 RC1', 'SMF 2.0 RC1-1', 'SMF 2.0 RC1 1', 'SMF 2.0 RC1.1', 'SMF 2.0 RC1.2')) || isset($settings['theme_version']) && (version_compare($settings['theme_version'], '2.0 RC2', '<') || strpos($settings['theme_version'], '2.0 Beta') !== false);
Reported to the ProjectTracker: http://simpleportal.net/index.php?issue=328.0

Title: Re: RC2 block border (tborder)
Post by: stikkki on December 10, 2009, 07:19:25 AM

thanx nathaniel, i'll check the edit out later

Title: Re: RC2 block border (tborder)
Post by: stikkki on December 10, 2009, 09:27:56 AM

i tried changing the coding but it made no difference

Title: Re: RC2 block border (tborder)
Post by: ccbtimewiz on December 10, 2009, 11:26:35 AM

Try this then...

Code: [Select]

$context['SPortal']['core_compat'] = true;

Title: Re: RC2 block border (tborder)
Post by: Nathaniel on December 15, 2009, 07:24:35 PM

Any updates on this issue stikkki? The edit posted by ccbtimewiz should definitely make this work. Although only in themes that need the compatibility code.

Title: Re: RC2 block border (tborder)
Post by: stikkki on December 16, 2009, 08:57:41 PM

Hi, sorry for the delay, the edit worked perfect, thanx