Topic: Permission Groups - <label> elements missing (minor issue)

[Garoun]

SMF: 2.0 RC3
SP: 2.3.2
Error Log: No Errors

Issue: <label> elements missing for Permission Groups (Edit Block/Pages/ect.).  As I said, not a big issue, but it does make it easier to check the boxes and closer to 508 compliance.

Main change I had made:
 

Code: [Select]

  <li><input type="checkbox" name="member_groups[',  $group['id'], ']" value="', $group['id'], '"',  !empty($group['checked']) ? ' checked="checked"' : '', '  class="input_check" /> <span', $group['is_post_group'] ? '  style="font-style: italic;"' : '', '>', $group['name'],  '</span></li>';
 
  => to =>
 

Code: [Select]

  <li><input type="checkbox" id="permission_groups-',  $group['id'], '" name="member_groups[', $group['id'], ']" value="',  $group['id'], '"', !empty($group['checked']) ? ' checked="checked"' :  '', ' class="input_check" /> <label for="permission_groups-',  $group['id'], '" ', $group['is_post_group'] ? ' style="font-style:  italic;"' : '', '>', $group['name'], '</label></li>';
 
I attached the updated file I'm using which I based off SMF's Board 'allowed groups'.

Note: It includes the 'Check All' option that was missing per SiNaN's post here: http://simpleportal.net/index.php?topic=5056.0

[Nathaniel]

Hmm, having a label instead of a span is not how SMF does this.

The SMF board 'allowed membergroups' permissions area uses the label element to contain both the input and span (with the name it it) elements. Like the example below:

Code: [Select]

<li><label for="permission_groups-',  $group['id'], '"><input type="checkbox" name="member_groups[',  $group['id'], ']" value="', $group['id'], '"',  !empty($group['checked']) ? ' checked="checked"' : '', '  class="input_check" /> <span', $group['is_post_group'] ? '  style="font-style: italic;"' : '', '>', $group['name'],  '</span></label></li>';

[Garoun]

The SMF version you posted is semantically correct also.  I was tired after working on the site most of the morning and got sloppy (aka reverted to <input></input><label></label> version).

You are correct though, I should have been consistent with the forum .

The key issue was the use of the <label> element.  In SP, prior to my tweak, it was using the <input> and <span> but omitted the <label> element.  As a result, the only way to select the checkboxes was to click them directly as opposed to their 'label' as well.

Unrelated:
I probably need to post a bug over on the SMF site also, because the 'Check All' option was missing the <label> as well.

[Nathaniel]

Again, while this isn't a bug and not really a feature either, it would be a sensible change to make.

Reported to the ProjectTracker: http://simpleportal.net/index.php?issue=394.0