Topic: Login Problem

[spuds]

SP 2.3.2
SMF 2.0 RC3

When a user enters their username and an incorrect password in to the user_info block they are redirected to the Login2 form as expected.  This form will be populated with the username they entered and expects them to enter the correct password to login to the forum, again as expected.

What I find is that on this form (login2), even when they enter the correct password, its rejected as invalid and they again find themselves at the login2 form. IF they enter over the username (that was pre filled in) and the correct password then it login as expected, its as though the username that you can see on the form is not being submitted.

As a temp work around I changed the user_info block action to be login and not login2, now when a wrong password is entered they are redirected to a blank login form (userid is not pre-populated) this forces them to enter both and then the form is submitted properly.

Edit ... although changing to login instead of login2 fixes the redirect it breaks the initial block login .... so dont do that !

[spuds]

I duplicated this behavior on this site.

Just use the user info login screen, entering a wrong password, than then you will get "stuck" on the login2 screen unless you type over the name that was pre-populated.  Leaving the name filled in and entering the password will just leave you on that screen.

[ccbtimewiz]

I was unable to reproduce this issue. What browser are you using?

[spuds]

FF 3.6.8

Just tested it again
1) logout
2) entered username and wrong password in the user info login box
3) was re-directed to the login2 form, my username was filled in
4) typed in my password and got the incorrect password notice and was still in the login2 form
5) tried again, same result
6) typed over my username with the same name and entered the password and everything was accepted.

[spuds]

Buller?, Anyone Buller?

[spuds]

Here is what it takes to fix this

in PortalBlocks.php find the sp_userInfo function

find

Code: [Select]

<form action="', $scripturl, '?action=login2" method="post" accept-charset="', $context['character_set'], '">

replace with

Code: [Select]

<form action="', $scripturl, '?action=login2" method="post" accept-charset="', $context['character_set'], '" ', empty($context['disable_login_hashing']) ? ' onsubmit="hashLoginPassword(this, \'' . $context['session_id'] . '\');"' : '', '>

find

Code: [Select]

</form>', sprintf($txt['welcome_guest'], $txt['guest_title']);
add before that line

Code: [Select]

<input type="hidden" name="hash_passwrd" value="" />


In Subs-Portal.php

find

Code: [Select]

      $context['html_headers'] .= '
   <script type="text/javascript" src="' . $settings['default_theme_url'] . '/scripts/portal.js"></script>
add after

Code: [Select]

   <script type="text/javascript" src="' . $settings['default_theme_url'] . '/scripts/sha1.js"></script>


[Nathaniel]

Confirmed. Thank you for the bug report and solution.

Reported to the ProjectTracker:
http://simpleportal.net/index.php?issue=404.0

[TheMortician4]

FF 3.6.8

Just tested it again
1) logout
2) entered username and wrong password in the user info login box
3) was re-directed to the login2 form, my username was filled in
4) typed in my password and got the incorrect password notice and was still in the login2 form
5) tried again, same result
6) typed over my username with the same name and entered the password and everything was accepted.

Upgrade your FireFox to the latest version with the bug and security fixes: 3.6.12