SimplePortal

Support => English Support => Topic started by: steve51184 on March 10, 2010, 05:44:43 AM

Title: shoutbox @ fix not working on my site
Post by: steve51184 on March 10, 2010, 05:44:43 AM

here's the problem:
http://simpleportal.net/index.php?topic=4168.msg26018#msg26018
or
http://simpleportal.net/index.php?topic=4126.msg25859#msg25859

here's the fix:
http://simpleportal.net/index.php?topic=4126.msg26219#msg26219

and here's my problem with the fix not working for me:
http://simpleportal.net/index.php?topic=4168.msg28682#msg28682


also before you all tell me to post in those topics etc:

Quote from: [SiNaN] on March 10, 2010, 05:35:12 AM

please start a new topic in English Support (http://simpleportal.net/index.php?board=11.0) board. Topics in Bugs board does not appear on our support topics list.

 8)

Title: Re: shoutbox @ fix not working on my site
Post by: [SiNaN] on March 10, 2010, 05:56:10 AM

Well, the problem is, I'm unable to reproduce the problem you are having. Any chance I can debug it myself? I will need a temporary FTP access only.

Title: Re: shoutbox @ fix not working on my site
Post by: steve51184 on March 10, 2010, 06:04:45 AM

could i not give you all the files you need but in .tar/.zip archive or something as i don't have ftp installed on my server

(i'm an scp man not and ftp man :P)

Title: Re: shoutbox @ fix not working on my site
Post by: [SiNaN] on March 10, 2010, 06:07:28 AM

Okay, all files in Sources and Themes directories + index.php would be enough.

Title: Re: shoutbox @ fix not working on my site
Post by: steve51184 on March 10, 2010, 06:10:32 AM

Quote from: [SiNaN] on March 10, 2010, 06:07:28 AM

Okay, all files in Sources and Themes directories + index.php would be enough.

pm sent ;)

Title: Re: shoutbox @ fix not working on my site
Post by: [SiNaN] on March 10, 2010, 06:20:03 AM

Okay. I could reproduce it but will check it later. Need to do my homework first.

Title: Re: shoutbox @ fix not working on my site
Post by: steve51184 on March 10, 2010, 06:26:03 AM

ok thank you :applause:

Title: Re: shoutbox @ fix not working on my site
Post by: MultiformeIngegno on March 11, 2010, 08:52:47 AM

any news on this..?

Title: Re: shoutbox @ fix not working on my site
Post by: steve51184 on March 11, 2010, 06:03:59 PM

Quote from: [SiNaN] on March 10, 2010, 06:20:03 AM

Okay. I could reproduce it but will check it later. Need to do my homework first.

any news on this?

Title: Re: shoutbox @ fix not working on my site
Post by: steve51184 on March 12, 2010, 10:40:04 PM

come on guys i've been waiting over a month for a fix now... i understand that your busy but i need help with this!

Title: Re: shoutbox @ fix not working on my site
Post by: [SiNaN] on March 14, 2010, 12:07:02 PM

I'm sorry. This is one of few issues I can't offer a solution without examining the code.

I tried it again and now can't reproduce it even with your files. I'll let Nath check this one as well.

Also, are you sure that you correctly replaced your Subs.php file with this one (http://simpleportal.net/index.php?topic=4168.msg29216#msg29216) and it didn't work?

Title: Re: shoutbox @ fix not working on my site
Post by: steve51184 on March 14, 2010, 12:32:40 PM

Quote from: [SiNaN] on March 14, 2010, 12:07:02 PM

I'm sorry. This is one of few issues I can't offer a solution without examining the code.

I tried it again and now can't reproduce it even with your files. I'll let Nath check this one as well.

Also, are you sure that you correctly replaced your Subs.php file with this one (http://simpleportal.net/index.php?topic=4168.msg29216#msg29216) and it didn't work?

VERY sure... i install ALL smf mods by hand and have done for years so i know how to make edits 8)

also is there not just an easy was to disable email addresses being posted in the shoutbox?

Title: Re: shoutbox @ fix not working on my site
Post by: [SiNaN] on March 15, 2010, 02:32:25 PM

I'm saying that because the original Subs.php file you attached had the first edit applied but not the second edit.

This issue is actually fixed with SMF 2.0 RC3. But to prevent e-mail address being parsed in shoutbox, this should be enough:

Code: (Find) [Select]

'text' => parse_bbc($row['body'], true, '', $bbc),

Code: (Replace) [Select]

'text' => parse_bbc(str_replace('@', '[at]', $row['body']), true, '', $bbc),

Title: Re: shoutbox @ fix not working on my site
Post by: steve51184 on March 15, 2010, 05:10:48 PM

Quote from: [SiNaN] on March 15, 2010, 02:32:25 PM

I'm saying that because the original Subs.php file you attached had the first edit applied but not the second edit.

This issue is actually fixed with SMF 2.0 RC3. But to prevent e-mail address being parsed in shoutbox, this should be enough:

Code: (Find) [Select]

'text' => parse_bbc($row['body'], true, '', $bbc),

Code: (Replace) [Select]

'text' => parse_bbc(str_replace('@', '[at]', $row['body']), true, '', $bbc),

is that in subs.php as i don't want to disable them for the whole forum

Title: Re: shoutbox @ fix not working on my site
Post by: [SiNaN] on March 16, 2010, 02:45:45 AM

Opps, sorry. It's in Subs-Portal.php. It will only affect shouts in the shoutbox.

Title: Re: shoutbox @ fix not working on my site
Post by: steve51184 on March 16, 2010, 03:50:20 AM

perfect thank you :)

Title: Re: shoutbox @ fix not working on my site
Post by: [SiNaN] on March 17, 2010, 01:31:21 PM

Regarding this issue, to quote myself from Beta Development board:

Quote from: [SiNaN] on March 17, 2010, 01:28:40 PM

Okay, I've found the issue. It was related to how SMF handles $disabled variable and how PHP handled static variables. Here is the fix:

Code: (Find) [Select]

$default_disabled = $disabled;

Code: (Replace) [Select]

$default_disabled = isset($disabled) ? $disabled : array();
When all tags are enabled, $disabed variable is not set by SMF, thus $default_disabed is not set until it reaches to shout parsing. At that point, $default_disabled is set according to shoutbox settings. I expected $disabled to throw out an error if it wasn't set, but looks like PHP initializes static variables as NULL, so it didn't cause an error, which made it quite difficult to find, especially if you don't allow all BBC tags.

Thanks goes to AngelinaBelle (http://simpleportal.net/index.php?action=profile;u=1730) for detailed report on the issue and allowing me to investigate the issue on her forum.

Title: Re: shoutbox @ fix not working on my site
Post by: MultiformeIngegno on March 17, 2010, 04:48:54 PM

Awesome news! Have you submitted it to mantis? :)

Title: Re: shoutbox @ fix not working on my site
Post by: [SiNaN] on March 18, 2010, 09:05:21 AM

It's already fixed in our latest dev package.

Title: Re: shoutbox @ fix not working on my site
Post by: MultiformeIngegno on March 18, 2010, 11:21:36 AM

Yes yes.. I was only wondering if it was an smf or sp bug.. if is the first you can add it to the mantis tracker at sm.org