SimplePortal
Development => Bugs => Fixed or Bogus Bugs => Topic started by: [SiNaN] on November 10, 2008, 06:04:06 AM
-
Subs.php
elseif(empty($_SERVER['QUERY_STRING']) && !empty($modSettings['portalactive']))
This won't work when viewing a page for portal. (action=articles;start=x) It should be decided by 'topic' and 'board'. Other actions already have their own menus set. If not set, 'home' button should be active.
My suggestion;
Find:
$current_action = empty($modSettings['portalactive']) ? 'home' : 'forum';
Replace:
$current_action = 'home';
Find:
elseif(empty($_SERVER['QUERY_STRING']) && !empty($modSettings['portalactive']))
$current_action = 'home';
Replace:
elseif((isset($_GET['board']) || isset($_GET['topic'])) && !empty($modSettings['portalactive']))
$current_action = 'forum';
-
Than we have the problem that it will be show as home if you click on "Show unread posts since last visit", "Show new replies to your posts" and if you use other actions. That it will be shown as Home even if it normal Forum. I think it's better to add the articel option to the checkup before, this would be easier. :).
Bye
DIN1031
-
Not really. We also have PHPSESSID added for some browsers.
Nothing wrong with showing the 'home' button active for 'unread' and 'unreadreplies' IMO. Better to leave it as it is and just check for 'board' and 'topic'.
-
Fixed in the dev version.
Marked as solved. :)