SimplePortal

Support => English Support => Topic started by: Talismen on May 21, 2009, 10:44:51 AM

Title: Install issue with SP mod and new SMF 1.1.9 patch
Post by: Talismen on May 21, 2009, 10:44:51 AM

All,

I'm attempting to install the patch for SMF 1.1.9 on my test site, before installing on my live site. I received an error that the "test failed" on my index.php file. It was similar to this error:

http://www.simplemachines.org/community/index.php?topic=311943.0

So, as indicated in that thread, I followed the instructions and attempted to manually edit the index.php file. Oddly enough, all other edits to the index.php file were performed, except this one:


<search for>
   elseif (empty($modSettings['allow_guestAccess']) && $user_info['is_guest'] && (!isset($_REQUEST['action']) || !in_array($_REQUEST['action'], array('coppa', 'login', 'login2', 'register', 'register2', 'reminder', 'activate', 'smstats', 'help', '.xml', 'verificationcode'))))
</search for>

<replace>
   elseif (empty($modSettings['allow_guestAccess']) && $user_info['is_guest'] && (!isset($_REQUEST['action']) || !in_array($_REQUEST['action'], array('coppa', 'login', 'login2', 'register', 'register2', 'reminder', 'activate', 'smstats', 'help', 'verificationcode'))))
</replace>



The trouble I've come across it that my existing index.php file looks like it modified for my SP mod:


   elseif (empty($modSettings['allow_guestAccess']) && !(!empty($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach' && !empty($_REQUEST['type']) && $_REQUEST['type'] == 'avatar') && !(empty($_REQUEST['action']) && empty($board) && empty($topic) && $modSettings['sp_portal_mode'] == 1) && $user_info['is_guest'] && (!isset($_REQUEST['action']) || !in_array($_REQUEST['action'], array('coppa', 'login', 'login2', 'register', 'register2', 'reminder', 'activate', 'smstats', 'help', '.xml', 'verificationcode'))))



How should I go about editing this line to bring it in compliance with what the security patch is trying to do? Any clues?

I don't normally like to manually edit anything unless I'm sure about what I'm doing, so I don't want to attempt to do this without asking the folks who know SP like the back of their hand ;)

PS - the only other mods I have intalled are the "Welcome Topic" mod, and the "Order News" mod. I recently tried the "SimpleShout box", but, that was only a test run. Also, my version of SP is 2.2.1.

Thanks all!
Tal

Title: Re: Install issue with SP mod and new SMF 1.1.9 patch
Post by: [SiNaN] on May 21, 2009, 11:19:25 AM

http://simpleportal.net/index.php?topic=2375.0

Title: Re: Install issue with SP mod and new SMF 1.1.9 patch
Post by: Talismen on May 21, 2009, 11:23:57 AM

Thank you Sinan!
Hope all is well with you! ;)