Topic: Undefined index: rightbar, leftbar, centerbar on every forum action

[el]

Hi to everyone.

I've made my search prior posting and I didn't find any similar, so I'm carrying on creating this topic. If there is already answered, please guide me accordingly.

I've recently jumped from tinyportal to Simpleportal. After succesfull installation, everything goes fine, except the error log which grows extremely rapid.

The following errors appear on almost every member's action on the forum.
I have tons of errors, all of which are like the following. More than 30.260 pages of errors in less than a month, all related to simple portal (except some occasionally wrong password entries from the members).

Forum specs:
SMF 1.1.11
SP 2.3.2
some mods installed, I'll post them if needed.
Members 1100+
Posts 120000+


8: Undefined index: rightbar
File: /var/www/html/forum/Themes/default/languages/Stats.english.php (main_below sub template - eval?)
Line: 293

8: Undefined index: centerbar
File: /var/www/html/forum/Themes/default/Display.template.php (main_above sub template - eval?)
Line: 280

8: Undefined index: leftbar
File: /var/www/html/forum/Themes/default/Display.template.php (main_above sub template - eval?)
Line: 270

8: Undefined index: leftbar
File: /var/www/html/forum/Themes/default/Post.template.php (main_above sub template - eval?)
Line: 270


8: Undefined index: leftbar
File: /var/www/html/forum/Themes/default/Recent.template.php (main_above sub template - eval?)
Line: 270

8: Undefined index: leftbar
File: /var/www/html/forum/Themes/default/BoardIndex.template.php (main_above sub template - eval?)
Line: 270

8: Undefined index: centerbar
File: /var/www/html/forum/Themes/default/MessageIndex.template.php (main_above sub template - eval?)
Line: 280

8: Undefined index: leftbar
File: /var/www/html/forum/Themes/default/Login.template.php (main_above sub template - eval?)
Line: 270

8: Undefined index: centerbar
File: /var/www/html/forum/Themes/default/Errors.template.php (main_above sub template - eval?)
Line: 280

8: Undefined index: rightbar
File: /var/www/html/forum/Themes/default/languages/Stats.english.php (main_below sub template - eval?)
Line: 293




Any guidelines will be rather helpful.

Thanks for reading.

[Nathaniel]

SMF's template eval is stopping us from seeing the "real' error message, could you please temporarily disable template eval on your forum and then post the error messages that are produced afterwards? Those error messages aren't giving the correct files/locations (eval doesn't work well with error messages).

Here is a mod that gives you an option to disable the template eval:
http://custom.simplemachines.org/mods/index.php?mod=2054
Here is a guide on disabling template eval via the database (if you don't want to install the mod):
http://www.simplemachines.org/community/index.php?topic=290186.0

[el]

Thank you for the reply.
It was helpful.

I did it through sql.
The new errors, indicate only one malfunctioning template, one of my theme's.


8: Undefined index: leftbar
File: /var/www/html/forum/Themes/Enterprise_smf11final_tp/index.template.php
Line: 270


Should I make the SP installation changes of Themes/default/index.template.php to my theme's index.template.php (Themes/Enterprise_smf11final_tp/index.template.php) too?

[Nathaniel]

As SimplePortal does not use a variable called 'leftbar', I suspect that there are pieces of TinyPortal's code that remain within your index.template.php file, if you want to stop the errors then they will need to be removed.

To use SimplePortal in Frontpage or Standalone modes you will need to add the "Forum" menu button/tab, which is the only edit that SimplePortal makes to that file. (The Forum integration mode doesn't need the "Forum" button as the boardindex is located at the "Home" tab)

Tutorial for adding the forum button: General Custom Theme Tutorial

[el]

Thank you for your reply.

I'll check my files and revert back here.

[Nathaniel]

Any updates on this issue el?

If you need help removing those leftover TP components, then please attach your index.template.php file.

[el]

Hi.

I checked the index.template.php and it was full of TP leftovers. Then I remembered, that the whole theme I was using was from TP because TP couldn't integrate to the forum's theme as SP can.

So, I am using a forum theme, specially made from TP, for TP and SMF.

I have the same theme (Enterprise) just for SMF (without TP), so I uploaded it's index.template.php (which doesn't has TP code leftovers), waited 2-3 minutes, and the mass errors stopped fulling the error log!
So you was absolutely right about the real problem.

Now, I've noticed that when I uploaded the SMF's theme, the "Forum" button disappeared. So I'll have to use the instructions you indicated, for regenerating it.

However, I am in a small dilemma.

Which is better?: Remove TP code leftovers from the TP's version theme index.template.php I'm using right now (and have the Forum button untouched) or edit the SMF's version theme index.template.php and add the Forum button?
I'm just afraid that by removing the index.template.php I'm using right now, I may create future problems and errors from mods I have installed (and I don't remember whether they use theme's index.template.php).

I attach both index.template.php files, renamed accordingly.

Thank you very much for your concern. I really appreciate it.


Just before I hit the post button in my reply to you, I added the forum button to the index.template.php of SMF's version theme (without TP code leftovers),  I uploaded it and for 5 minutes now, everything goes fine with no errors and I have the forum button in place. But I'm still worried, so your suggestions remain still highly valuable.

I attach also the forum button added index.template.php.

[Nathaniel]

From doing a diff between the "index.template_(TP code inside).php" and "index.template_(SMF only.WO TP code inside).php" files, it appears that there are a few edits made by some mods to your 'index.template.php' file, although it would be easiest to make those edits to the clean file.

I have attached that diff (its just a plain text file), although don't worry if you aren't sure exactly what it means. Basically lines starting with '>' exist in the "index.template_(TP code inside).php" file only, replacing the lines which start with a '<' that come from the ""index.template_(SMF only.WO TP code inside).php"" file.

Below are the edits I think you need to make to your 'clean' index.template.php file, so that your mods will function correctly.

Code: ("Find (related to some metadata mod)") [Select]

<meta name="description" content="', $context['page_title'], '" />', empty($context['robot_no_index']) ? '' : '
<meta name="robots" content="noindex" />', '
<meta name="keywords" content="PHP, MySQL, bulletin, board, free, open, source, smf, simple, machines, forum" />

Code: ("Replace") [Select]

';
echo (!empty($modSettings['meta_description'])) ? ' <meta name="description" content="'. $modSettings['meta_description'] .'" />' : '<meta name="description" content="'. $context['page_title'] .'" />', empty($context['robot_no_index']) ? '' : '
<meta name="robots" content="noindex" />';
echo (!empty($modSettings['meta_keywords'])) ? '
<meta name="keywords" content="'. $modSettings['meta_keywords'] .'" />' : '';
echo (!empty($modSettings['meta_copyright'])) ? '
<meta name="copyright" content="'. $modSettings['meta_copyright'] .'" />' : '';
echo (!empty($modSettings['meta_author'])) ? '
<meta name="author" content="'. $modSettings['meta_author'] .'" />' : '';
echo '

Code: ("Find (some sort of icon related mod)") [Select]

<title>', $context['page_title'], '</title>';

Code: ("Replace") [Select]

<title>', $context['page_title'], '</title>';


// IF WE HAVE AN ICON, SHOW IT
if ((!empty($settings['header_icon_url'])) && (!empty($settings['header_icon_type']))) {

if ($settings['header_icon_type'] == 0) {
// ICO SO USE THE OLD FASHIONED CODE
  echo '
  <link rel="shortcut icon" type="image/x-icon" href="' , $settings['header_icon_url'] , '"/>';
} else {
// ELSE ITS A NEWER ICON FOR MODERN BROWSERS (GIF/PNG)
echo '
<link rel="icon" type="image/' , ($settings['header_icon_type'] == 1) ? 'gif' : 'png' , '" href="' , $settings['header_icon_url'] , '"/>';
}
}




Code: ("Find (some sort of registration bar mod)") [Select]

<link rel="stylesheet" type="text/css" href="', $settings['default_theme_url'], '/print.css?fin11" media="print" />';

Code: ("Replace") [Select]

<link rel="stylesheet" type="text/css" href="', $settings['default_theme_url'], '/print.css?fin11" media="print" />
<link rel="stylesheet" type="text/css" href="', $settings['theme_url'], '/regbar.css" />';

Code: ("Find (some sort of registration bar mod)") [Select]

<body>';

Code: ("Replace") [Select]

<body>';
if($context['user']['is_guest'] && $context['current_action'] != 'register')
echo '<table width="100%" border="0" cellspacing="0" cellpadding="0"><tr><td width="100%"><div id="infobar"><a href="' . $scripturl . '?action=register"><p>' . $txt['regbar_text'] . '</p></a></div></td></tr></table>';


All the other edits look like TP ones to me, I can see why you wouldn't have any errors without making those edits above, however those three mods won't work as intended if you don't make those edits.

[el]

Thank you very much for your such a detailed answer!

I'll study both diff.txt and the changes you quoted me in your post and I'll revert back here.

[el]

Hi.
I've made the changes you noted and everything seems to work like charm!

Thank you again!

Best Regards.

[Nathaniel]

I'm glad that you got it working.

If you want to make absolutely sure that there aren't any more edits, then you could go through each of your mods, clicking on 'uninstall' (don't actually uninstall the mod, just look at the process ) so that you can see the edits that the mod would undo for the index.template.php file, that is another way of checking that there aren't any missing bits, although it could take a while if you have a lot of mods.

Anyway, marked as solved.

[el]

thankx for the tip.
Unfortunately though, during upgrade to SMF 1.1.11 the installation logs were destroyed. So now I can only see "List files" and "Delete".