SimplePortal

Development => Bugs => Fixed or Bogus Bugs => Topic started by: Saviour on November 23, 2008, 08:25:56 PM

Title: Failing W3C XHTML Validation...
Post by: Saviour on November 23, 2008, 08:25:56 PM
Love this mod, guys...but it seems to break XHTML validation...

Is this being worked on?

You can check this by validating your site...or you can see the results of mine:

http://validator.w3.org/check?uri=http%3A%2F%2Fwww.saviourpc.com%2Fforums%2Findex.php

Thanks for looking...
Title: Re: Failing W3C XHTML Validation...
Post by: [SiNaN] on November 24, 2008, 06:53:25 AM
These are fixed.
Title: Re: Failing W3C XHTML Validation...
Post by: Saviour on November 24, 2008, 08:02:43 AM
These are fixed.

Blue Dream...

Sweet...glad it's fixed!  Now if I can get some help with the block I'm looking for...everything will be "Peaches and Cream"...

Thanks for the quick fix!


All my best...

Steve
Title: Re: Failing W3C XHTML Validation...
Post by: Saviour on November 24, 2008, 08:40:12 AM
BlueDream...

I guess I spoke too soon...

I uninstalled the portal...downloaded the fixed version...reinstalled...and all was well...until I moved some blocks around.  As soon as you do that...it breaks the XHTML validation...again.


Steve
Title: Re: Failing W3C XHTML Validation...
Post by: [SiNaN] on November 24, 2008, 09:23:09 AM
It's fixed in 2.1, which is not released yet.
Title: Re: Failing W3C XHTML Validation...
Post by: Saviour on November 24, 2008, 09:45:29 AM
It's fixed in 2.1, which is not released yet.

Thanks for the info...

Any idea as to the date of its scheduled release?
Title: Re: Failing W3C XHTML Validation...
Post by: Eliana Tamerin on November 24, 2008, 10:44:14 AM
When it's ready.
Title: Re: Failing W3C XHTML Validation...
Post by: Saviour on November 24, 2008, 01:04:36 PM
Well, that certainly makes sense...

Who pi**ed in your Corn Flakes? :D
Title: Re: Failing W3C XHTML Validation...
Post by: Saviour on November 27, 2008, 11:52:53 AM
It's fixed in 2.1, which is not released yet.

Well...it would appear it's not.

Please take a look at the following and you will see a <td> tag has not been closed:

W3C XHTML Validation of My Portal Page Including Source (http://validator.w3.org/check?uri=http%3A%2F%2Fwww.saviourpc.com%2Fforums%2Findex.php&charset=(detect+automatically)&doctype=Inline&ss=1&group=0&user-agent=W3C_Validator%2F1.606)
Title: Re: Failing W3C XHTML Validation...
Post by: [SiNaN] on November 27, 2008, 11:58:04 AM
You are using articles feature right?

And I'd be glad if you can report if you find more.
Title: Re: Failing W3C XHTML Validation...
Post by: Saviour on November 27, 2008, 12:19:31 PM
Yes...

That seems to be the only issue I'm having at the moment.  While I know there may be some known bugs, with the new version of SP, I will keep you informed of other validation issues.

Thanks...
Title: Re: Failing W3C XHTML Validation...
Post by: Saviour on November 27, 2008, 07:59:56 PM
Bumping my own post...sorry...

Anyway...the last XHTML validation link I posted, initially, had only one error.  There are now 15 errors.

Now...I'm not being picky, but to be totally honest...there are those out there (myself included) that would like to see this mod pass XHTML validation.

We were told that it would be fixed in this latest release...however, it has not.  No offense...I think you guys are doing a fine job with this portal.

It's freakin' awesome!  I absolutely love it!

However, XHTML validation means a lot to me...and this mod doesn't pass in that respect.  Check your own site with the XHTML link you have at the bottom of any of your site's pages and you'll see what I mean.

My question is this:  Is XHTML validation being overlooked here...or is it currently being addressed?  I know there are some known bugs that are being worked on...and I think this should be addressed with the same priority you're giving to the reported bugs, as well.

Just my opinion...and I don't mean to upset anyone...I'm just showing my concern and voicing an opinion.

Again...Awesome!
Title: Re: Failing W3C XHTML Validation...
Post by: Jade Elizabeth on November 27, 2008, 08:38:03 PM
It's being addressed, sorry for the inconvenience.
Title: Re: Failing W3C XHTML Validation...
Post by: Saviour on November 27, 2008, 09:57:27 PM
No problem, Jade...

If it helps at all...based on the blocks I currently have on my portal page...it would seem that (so far) the Articles and the Board News block seem to be two of the culprits.

If I remove those from the portal page, the page passes XHTML validation.


Just a heads up...
Title: Re: Failing W3C XHTML Validation...
Post by: Jade Elizabeth on November 27, 2008, 10:31:34 PM
Thanks, we appreciate it :D
Title: Re: Failing W3C XHTML Validation...
Post by: Jade Elizabeth on November 28, 2008, 12:50:07 AM
Can you check your theme validates? I mean you have mods on it that could be interfering with SP or something?...

http://validator.w3.org/check?uri=http%3A%2F%2Fwww.bunnyrabbitsex.com%2Findex.php

My page validates and I have articles..

Well...it would appear it's not.

Please take a look at the following and you will see a <td> tag has not been closed:

W3C XHTML Validation of My Portal Page Including Source (http://validator.w3.org/check?uri=http%3A%2F%2Fwww.saviourpc.com%2Fforums%2Findex.php&charset=(detect+automatically)&doctype=Inline&ss=1&group=0&user-agent=W3C_Validator%2F1.606)

And that is validating for me too..
Title: Re: Failing W3C XHTML Validation...
Post by: [SiNaN] on November 28, 2008, 07:14:34 AM
Now...I'm not being picky, but to be totally honest...there are those out there (myself included) that would like to see this mod pass XHTML validation.
My question is this:  Is XHTML validation being overlooked here...or is it currently being addressed?  I know there are some known bugs that are being worked on...and I think this should be addressed with the same priority you're giving to the reported bugs, as well.

I can well understand your concerns. Of course it is not overlooked, but portal page can get ~20 pieces and it is quite easy to make a typo while working on them. Thanks for the input, hopefully they will be fixed.
Title: Re: Failing W3C XHTML Validation...
Post by: Saviour on November 28, 2008, 01:52:20 PM
I found out why SimplePortal 2.1 was failing XHTML validation.

It has to do with the following:

1.  File SPortal1-1.template.php shows this code:  <td style="padding: 5px;"colspan="2">
, when, in fact, the code should be <td style="padding: 5px;" colspan="2">.  You forgot a space.  You also forgot to close the <td> tag for that line of code.

2.  File SPortal1-1.php has the same code error, as above...however, you did manage to close the <td> tag for that line of code.

After I made the changes...the portal page now passes XHTML validation.


Just thought you'd like to know...

Steve
Title: Re: Failing W3C XHTML Validation...
Post by: Jade Elizabeth on November 28, 2008, 01:55:10 PM
Thanks for that fix :D
Title: Re: Failing W3C XHTML Validation...
Post by: Runic on November 28, 2008, 01:58:21 PM
in all actualiy the style should become a class
Title: Re: Failing W3C XHTML Validation...
Post by: Saviour on November 28, 2008, 02:01:19 PM
Thanks for that fix :D

You're welcome...

in all actualiy the style should become a class

I'll leave that to the professionals... :D
Title: Re: Failing W3C XHTML Validation...
Post by: Jade Elizabeth on November 28, 2008, 02:16:21 PM
I was thinking that too... but it IS only padding.
Title: Re: Failing W3C XHTML Validation...
Post by: Runic on November 28, 2008, 02:17:42 PM
still poor coding practice
Title: Re: Failing W3C XHTML Validation...
Post by: Jade Elizabeth on November 28, 2008, 02:26:02 PM
Well we could get into an entire debate over that lol
Title: Re: Failing W3C XHTML Validation...
Post by: Runic on November 28, 2008, 02:29:06 PM
maybe so however do you not think maybe same reason why its being removed from SMF coding as its poor practice :)
Title: Re: Failing W3C XHTML Validation...
Post by: Jade Elizabeth on November 28, 2008, 02:44:34 PM
LOL bring SMF into it.

Well, maybe SMF 2.0 has a class for it, and 1.1 can have it added ;)
Title: Re: Failing W3C XHTML Validation...
Post by: Saviour on November 28, 2008, 02:48:24 PM
Uh-oh...Look what I started...
Title: Re: Failing W3C XHTML Validation...
Post by: Jade Elizabeth on November 28, 2008, 02:49:20 PM
LOL your sarcasm disorder needs to be looked at ;)

(I'm kidding, I think you're a hoot! ;D (that wasnt sarcasm, for the record))
Title: Re: Failing W3C XHTML Validation...
Post by: Runic on November 28, 2008, 05:21:35 PM
Well, maybe SMF 2.0 has a class for it, and 1.1 can have it added ;)

why not just make it simpler and adhere to good coding standards looks better for SP
Title: Re: Failing W3C XHTML Validation...
Post by: [SiNaN] on November 30, 2008, 06:19:04 AM
We will have some arrangements for that, not worries.

And Saviour, those all should have been fixed in 2.1.1.
Title: Re: Failing W3C XHTML Validation...
Post by: Saviour on November 30, 2008, 09:38:49 AM
Thanks, Blue Dream...no problems...as of yet...except for the Board News block...bug.
SimplePortal 2.3.8 © 2008-2024, SimplePortal