SimplePortal

Support => English Support => Topic started by: willerby on January 03, 2010, 04:35:05 PM

Title: Guests causing errors in log when viewing attachments
Post by: willerby on January 03, 2010, 04:35:05 PM

Having recently upgraded to SMF RC2 and Simple Portal 2.3.1 using Curver theme, I am getting a couple of hundred erros in the log each day which seem to be guests trying to view attachments in posts.

Possibly Simple Portal related but not sure...

Errors in batches as follows:

Guest
b58f1f091ca71340b2b470c22881efc1
http://www.xxx.com/forum/index.php?action=dlattach;topic=161.0;attach=112
8: Undefined index: is_guest
File: /home2/xxx/public_html/forum/Sources/Subs-Portal.php
Line: 257

b58f1f091ca71340b2b470c22881efc1
http://www.xxx/forum/index.php?action=dlattach;topic=161.0;attach=112
8: Undefined index: session_id
File: /home2/xxx/public_html/forum/Sources/Subs-Portal.php
Line: 203

b58f1f091ca71340b2b470c22881efc1
http://www.xxx/forum/index.php?action=dlattach;topic=161.0;attach=112
8: Undefined index: is_guest
File: /home2/xxx/public_html/forum/Sources/Subs-Portal.php
Line: 201

b58f1f091ca71340b2b470c22881efc1
http://www.xxx/forum/index.php?action=dlattach;topic=161.0;attach=112
8: Undefined index: session_var
File: /home2/xxx/public_html/forum/Sources/Subs-Portal.php
Line: 187

b58f1f091ca71340b2b470c22881efc1
http://www.xxx/forum/index.php?action=dlattach;topic=161.0;attach=112
8: Undefined index: session_id
File: /home2/xxx/public_html/forum/Sources/Subs-Portal.php
Line: 187

b58f1f091ca71340b2b470c22881efc1
http://www.xxx/forum/index.php?action=dlattach;topic=161.0;attach=112
8: Undefined index: is_guest
File: /home2/xxx/public_html/forum/Sources/Subs-Portal.php
Line: 182

b58f1f091ca71340b2b470c22881efc1
http://www.xxx/forum/index.php?action=dlattach;topic=161.0;attach=112
8: Undefined index: right_to_left
File: /home2/xxx/public_html/forum/Sources/Subs-Portal.php
Line: 105

b58f1f091ca71340b2b470c22881efc1
http://www.xxx/forum/index.php?action=dlattach;topic=161.0;attach=112
8: Undefined index: html_headers
File: /home2/xxx/public_html/forum/Sources/Load.php
Line: 1875

b58f1f091ca71340b2b470c22881efc1
http://www.xxx/forum/index.php?action=dlattach;topic=161.0;attach=112
8: Undefined index: html_headers
File: /home2/xxx/public_html/forum/Sources/Load.php
Line: 1869

b58f1f091ca71340b2b470c22881efc1
http://www.xxx/forum/index.php?action=dlattach;topic=161.0;attach=112
8: Undefined index: is_admin
File: /home2/xxx/public_html/forum/cache/lang_SPortal_english_default.php
Line: 119

Any ideas?

Errors occur whether guests are allowed to view attachments or not. Would therefore seem to be spiders revisiting images previously accessed as human users would not be able to access that URL and would not try as often as when images denied. ???

Thanks

W

Title: Re: Guests causing errors in log when viewing attachments
Post by: Nathaniel on January 04, 2010, 08:43:51 AM

I believe that your issue is related to this SMF bug: http://dev.simplemachines.org/mantis/view.php?id=3862

Forcing the theme to load even for attachments should fix this issue.

Try the edit below:

Code: ("Find (index.php)") [Select]

// Attachments don't require the entire theme to be loaded.
if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach' && (!empty($modSettings['allow_guestAccess']) && $user_info['is_guest']))
detectBrowser();
// Load the current theme.  (note that ?theme=1 will also work, may be used for guest theming.)
else
loadTheme();

Code: [Select]

// Attachments don't require the entire theme to be loaded.
/*if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach' && (!empty($modSettings['allow_guestAccess']) && $user_info['is_guest']))
detectBrowser();
// Load the current theme.  (note that ?theme=1 will also work, may be used for guest theming.)
else*/
loadTheme();

Title: Re: Guests causing errors in log when viewing attachments
Post by: willerby on January 04, 2010, 12:30:03 PM

Ah! Thanks Nathaniel. That would explain it.

Will try out the fix tonight.

W

Title: Re: Guests causing errors in log when viewing attachments
Post by: willerby on January 04, 2010, 05:07:25 PM

Work a treat. No further errors in log since making those changes. Thanks...

Title: Re: Guests causing errors in log when viewing attachments
Post by: Mick. on January 19, 2010, 08:25:24 PM

Excellent, thanx.

Title: Re: Guests causing errors in log when viewing attachments
Post by: Dummbock on March 16, 2010, 07:05:12 AM

Hi Nathaniel  :nervous-happy:

it works not on smf 2.0 RC 3

Anny idea?

Thanks