SimplePortal

Development => Bugs => Fixed or Bogus Bugs => Topic started by: andy on November 27, 2011, 08:29:43 AM

Title: Block preview reseting permissions to disallow 'X'
Post by: andy on November 27, 2011, 08:29:43 AM

I posted a message about this on the custom code recent topics block.

Seems like a bug ...

When I edit a block (custom permissions) in SP 2.3.4 and click preview, all the permissions are reset to disallow 'X'.

Just tested on 2 other blocks and the same - preview is reseting all permissions.

Andy

Title: Re: Block preview reseting permissions to disallow 'X'
Post by: [SiNaN] on November 29, 2011, 01:14:31 PM

Thank you for the report. Indeed, it's a bug in 2.3.4. Here's the fix:

PortalAdminBlocks.php

Code: (Find) [Select]

}

$context['SPortal']['block'] = array(

Code: (Replace) [Select]

}

$permission_set = 0;
$groups_allowed = $groups_denied = array();

if (!empty($_POST['permission_set']))
$permission_set = (int) $_POST['permission_set'];
elseif (!empty($_POST['membergroups']) && is_array($_POST['membergroups']))
{
foreach ($_POST['membergroups'] as $id => $value)
{
if ($value == 1)
$groups_allowed[] = (int) $id;
elseif ($value == -1)
$groups_denied[] = (int) $id;
}
}

$context['SPortal']['block'] = array(

Code: (Find) [Select]

'permission_set' => $_POST['permission_set'],
'groups_allowed' => !empty($_POST['groups_allowed']) ? $_POST['groups_allowed'] : array(),
'groups_denied' => !empty($_POST['groups_denied']) ? $_POST['groups_denied'] : array(),

Code: (Replace) [Select]

'permission_set' => $permission_set,
'groups_allowed' => $groups_allowed,
'groups_denied' => $groups_denied,

Title: Re: Block preview reseting permissions to disallow 'X'
Post by: AussieBill on November 29, 2011, 03:52:10 PM

Quote from: igirisjin on November 27, 2011, 08:29:43 AM

When I edit a block (custom permissions) in SP 2.3.4 and click preview, all the permissions are reset to disallow 'X'.

It's happening on pages as well :0

Title: Re: Block preview reseting permissions to disallow 'X'
Post by: andy on November 30, 2011, 08:35:39 AM

Does it with pages too on preview.

Title: Re: Block preview reseting permissions to disallow 'X'
Post by: [SiNaN] on November 30, 2011, 01:01:25 PM

Right. Here's the fix for pages area:

Sources/PortalAdminPages.php

Code: (Find) [Select]

if (!empty($_POST['preview']))
{
$context['SPortal']['page'] = array(

Code: (Replace) [Select]

if (!empty($_POST['preview']))
{
$permission_set = 0;
$groups_allowed = $groups_denied = array();

if (!empty($_POST['permission_set']))
$permission_set = (int) $_POST['permission_set'];
elseif (!empty($_POST['membergroups']) && is_array($_POST['membergroups']))
{
foreach ($_POST['membergroups'] as $id => $value)
{
if ($value == 1)
$groups_allowed[] = (int) $id;
elseif ($value == -1)
$groups_denied[] = (int) $id;
}
}

$context['SPortal']['page'] = array(

Code: (Find) [Select]

'permission_set' => $_POST['permission_set'],
'groups_allowed' => !empty($_POST['groups_allowed']) ? $_POST['groups_allowed'] : array(),
'groups_denied' => !empty($_POST['groups_denied']) ? $_POST['groups_denied'] : array(),

Code: (Replace) [Select]

'permission_set' => $permission_set,
'groups_allowed' => $groups_allowed,
'groups_denied' => $groups_denied,

Title: Re: Block preview reseting permissions to disallow 'X'
Post by: [SiNaN] on December 02, 2011, 08:56:55 AM

Tracked here:

http://simpleportal.net/index.php?issue=451.0

Title: Re: Block preview reseting permissions to disallow 'X'
Post by: [SiNaN] on February 23, 2012, 08:36:21 AM

Fixed in our dev version.