SimplePortal

Development => Bugs => Fixed or Bogus Bugs => Topic started by: FrizzleFried on April 03, 2012, 04:08:46 PM

Title: Tiny Menu Bug
Post by: FrizzleFried on April 03, 2012, 04:08:46 PM

Default theme (modified).

The top menu... when you click HOME or when you drop in to the site the HOME button is "lit up" orange.  When you click FORUM the FORUM button lights up (orange)... but when I click in to a category the "HOME" button re-lights up rather than staying on the "FORUM" button.

How can I rectify that behavior?

Thanks!

Title: Re: Tiny Menu Bug
Post by: FrizzleFried on April 05, 2012, 03:04:01 PM

...and suggestions on where to look? Thanks!

Title: Re: Tiny Menu Bug
Post by: andy on April 07, 2012, 02:46:20 PM

Seeing it might help .... it is probably your theme but could be related to changes made to the home link. I dont know much about this though.

Title: Re: Tiny Menu Bug
Post by: FrizzleFried on April 07, 2012, 06:44:22 PM

Default theme.   I don't think I've done anything RE: the home button specifically but I did remove the HELP button from the main menu and I also have added a number of items (arcade, quiz, etc)...

Basically the way it behaves is:

HOME it remains orange...

Click forum and FORUM turns orange and HOME turns to unlit.

Click any of the forum categories and it drops back to HOME as lit when it is supposed to stay at FORUM (as it is above on this forum... FORUM is lit right now... on mine,  it would have HOME lit).

The site is a private site,  but if you think it would help I could set you up an account.

Thanks!

Friz

Title: Re: Tiny Menu Bug
Post by: ccbtimewiz on April 07, 2012, 11:02:20 PM

Confirmed, the collapse action has "home" highlighted as opposed to "forum". It's a bug, here's the fix:

Open ./Sources/Subs.php

Find:

Code: [Select]

in_array($context['current_action'], array('unread', 'unreadreplies', 'recent', 'stats', 'who'))
Replace with:

Code: [Select]

in_array($context['current_action'], array('collapse', 'unread', 'unreadreplies', 'recent', 'stats', 'who'))

Title: Re: Tiny Menu Bug
Post by: FrizzleFried on April 08, 2012, 12:02:54 PM

I'd like to report that while I evidently discovered this bug on accident... it wasn't the solution to my problem... My problem had nothing to do with collapsing.  HOWEVER... pulling a search on the string above failed... which caused me to look in to the issue... and compare a fresh SMF/Simple Portal installation with my modified one in that area and I discovered the entire line that this change is to be made on was missing from my subs.php file!   After installing the line (and making the correction above) the button is now working as intended!

THANK YOU!

Title: Re: Tiny Menu Bug
Post by: [SiNaN] on August 14, 2014, 04:13:14 PM

Fixed for the upcoming release.