SimplePortal

Development => Bugs => Fixed or Bogus Bugs => Topic started by: avepeachy on May 08, 2012, 10:48:38 PM

Title: Who's Online Unknown Action
Post by: avepeachy on May 08, 2012, 10:48:38 PM
EDIT: It wasn't the shoutbox, it is simpleportal period.

I am running SMF 2.0.2 and SimplePortal 2.3.5

Whenever I have simpleportal enabled on my forum, ALL of my member actions under Who's Online are displayed as "unknown action." Is there any way to return the list functionality? Myself and my members use this feature frequently and I don't want to lose simpleportal just to return it.
Title: Re: Who's Online Unknown Action
Post by: avepeachy on May 15, 2012, 06:06:07 PM
Anyone? Bueller? Bueller?
Title: Re: Who's Online Unknown Action
Post by: Normally on May 15, 2012, 06:09:47 PM
I have the same.


Stef.
Title: Re: Who's Online Unknown Action
Post by: abvs on May 28, 2012, 07:26:19 AM
also have this problem...
Title: Re: Who's Online Unknown Action
Post by: Kryzen on May 28, 2012, 07:42:40 AM
I can't reproduce this problem on this site and I don't have access to my local Simple Portal installation right now, but what blocks are enabled? Do you have any other mods installed?
Title: Re: Who's Online Unknown Action
Post by: Normally on June 06, 2012, 07:39:33 PM
If you want i can give you a administrator account?
Than you can see what happens.

Stef.
Title: Re: Who's Online Unknown Action
Post by: AngelinaBelle on June 07, 2012, 08:57:20 AM
As you can see, on this site, Who's online gives information about most users online:
http://simpleportal.net/index.php?action=who;start=0;show=all;sort=user

The issue may have to do with the actions chosen.  It may have to do with other mods installed. It may take some time to track down the problem.
Title: Re: Who's Online Unknown Action
Post by: Aimee on June 22, 2012, 04:30:54 AM
I have this problem too.  I'll see what I can find internally.

The site I'm now doing has a bunch of packages:
Stars And Badges      2.2
AjaxChat Integration   3.2.2b
WYSIWYG Quick Reply   2.3
SMF 2.0.2 Update      1.0
Order Custom Profile Fields    1.1.1
Member NotePad      2.0.2
Karma Description Mod   2.7.1
Tapatalk SMF 2.0 RC4/RC5/Final Plugin   3.0.0
Switch Permissions   1.0
Member Color Link      3.1
SMFShop         3.1.7
Post Unapproval      1.1.4
Aeva Media      1.4w
SimplePortal      2.3.5
SMF Staff Page      1.7
SMF Bay         2.0rc1
Member Awards      2.2.3
SMF Links      2.3.2
Topic Solved      1.1.1
Bookmarks      2.3

Thank you!
Title: Re: Who's Online Unknown Action
Post by: AngelinaBelle on June 22, 2012, 07:59:15 AM
That is a very long list of mods.

If you want to figure out the problem, you could try uninstalling mods in the reverse order they were installed, looking each time to see if/when the problem goes away.

Please give this a try.
Title: Re: Who's Online Unknown Action
Post by: Aimee on June 22, 2012, 09:30:02 AM
Ok; I can do that on my development system.

Here's some more info on what I've seen so far.

Who's Online seems to work ok; the problem is that the url_list from which it's working (about line 325 in Who.php) does not have the right level of detail -- as though every shoutbox update (mine is set to 30 seconds) supersedes the post/display info.  Maybe that helps you, but I'll also try to track it back to the origin of the url_list.

Thanks so far.
Title: Re: Who's Online Unknown Action
Post by: AngelinaBelle on June 22, 2012, 11:04:52 AM
Tracking it back to the url_list could help you make sense of it. 

And remember -- this is not just about Simple Portal. Whois works fine on SimplePortal.net, for example.

It seems like it is some collision with some other thing. Or a larger collision between a number of mods.
Or dependant on one or more settings.
If you can narrow it down, you'll have a lot more to go on.

Could be a pain to figure out; good luck!
Title: Re: Who's Online Unknown Action
Post by: Aimee on June 22, 2012, 04:09:32 PM
Ok the salient part is in the writeLog function in Subs.php, which uses session info to write to {db_prefix}log_online from session data, which is then re-read in Who's Online.

I'm starting to think that it's related to the following effect:  If I let my browser sit and just watch the shoutbox, the user never "falls off the bottom" of Who's Online, whereas it used to in 2.3.3.  It's as though the shoutbox now automatically and actively issues a shoutbox-refresh statement rather than passively waiting for more content.  Stated differently, Who's Online is accurate until the first shoutbox refresh.

Should be able to remove modules this weekend.
Title: Re: Who's Online Unknown Action
Post by: Metacritter on June 22, 2012, 06:50:46 PM
I am seeing the same effect on my 2.0.2-2.3.5 forum with very few mods.

Tracing past the writeLog() function, I noticed this in my index.php smf_main()

Shouldn't writeLog() be inside the "// Don't track stats of portal xml actions" block?  Stepping over the code skips that block from a shoutbox refresh but not from a page load, so the detection appears to be working as the comment indicates.

Lines 192-205 of index.php
Code: [Select]
    // Do some logging, unless this is an attachment, avatar, toggle of editor buttons, theme option, XML feed etc.
    if (empty($_REQUEST['action']) || !in_array($_REQUEST['action'], array('dlattach', 'findmember', 'jseditor', 'jsoption', 'requestmembers', 'smstats', '.xml', 'xmlhttp', 'verificationcode', 'viewquery', 'viewsmfile')))
    {
        // Log this user as online.
        writeLog();

        // Don't track stats of portal xml actions.
        if (empty($_REQUEST['action']) || $_REQUEST['action'] != 'portal' || !isset($_GET['xml']))
        {
            // Track forum statistics and hits...?
            if (!empty($modSettings['hitStats']))
                trackStats(array('hits' => '+'));
        }
    }



[Edit: From here down.  Tested and reporting a fix on my install]
Changed the placement of writeLog(), confirmed that I'm back to the behavior I expected to see from 2.3.3.  (No "Who's Online" time bump for users idling on a page containing an auto-refreshing shoutbox, normal bumps for normal navigation.) 
Code: [Select]
// Do some logging, unless this is an attachment, avatar, toggle of editor buttons, theme option, XML feed etc.
if (empty($_REQUEST['action']) || !in_array($_REQUEST['action'], array('dlattach', 'findmember', 'jseditor', 'jsoption', 'requestmembers', 'smstats', '.xml', 'xmlhttp', 'verificationcode', 'viewquery', 'viewsmfile')))
{
// Don't track stats of portal xml actions.
if (empty($_REQUEST['action']) || $_REQUEST['action'] != 'portal' || !isset($_GET['xml']))
{

// Log this user as online.
writeLog();

// Track forum statistics and hits...?
if (!empty($modSettings['hitStats']))
trackStats(array('hits' => '+'));
}
}

Aimee, I notice that you talked about prior behavior in 2.3.3.  Did you skip 2.3.4?  I jumped versions from 2.3.3 to 2.3.5.  I wonder if this causes issues with how the install is applied?
Title: Re: Who's Online Unknown Action
Post by: Aimee on June 22, 2012, 08:55:46 PM
You're onto something.  If the session data is loaded differently than in 2.3.3, which I've seen it is, then it could confuse the code you've highlighted and other code dependent on the session objects such as the contents of Who's Online.

When I saw that 2.3.5 said to uninstall SP entirely, I took that to mean 2.3.5 is, like, self-contained.

Further, I've seen that my guests (spiders, mostly) both age out and work in who's online correctly.
Title: Re: Who's Online Unknown Action
Post by: Aimee on June 22, 2012, 09:54:41 PM
Yes, Metacritter, I skipped 2.3.4.  Just now I went back to 2.3.3, then did 2.3.4, then 2.3.5.  Same weird symptoms; no difference.

Made the (very sensible) change you suggested, and everything is good now  :)

This is Solved for me!  Thank you very much!
Title: Re: Who's Online Unknown Action
Post by: Metacritter on June 22, 2012, 10:02:48 PM
That's great!  And thank you very much!  Without your pointer on where to start looking, this would surely have taken me ages to figure out.  :)
Yes, Metacritter, I skipped 2.3.4.  Just now I went back to 2.3.3, then did 2.3.4, then 2.3.5.  Same weird symptoms; no difference.

Made the (very sensible) change you suggested, and everything is good now  :)

This is Solved for me!  Thank you very much!
Title: Re: Who's Online Unknown Action
Post by: Normally on July 10, 2012, 07:01:19 AM
Thanks,

This works very good.

Stef.
Title: Re: Who's Online Unknown Action
Post by: avepeachy on July 23, 2012, 03:15:23 PM
I think this may have gone off course... My problem isn't with displaying who's online, it's with displaying their actions.

When I click to view who's online and see what they are doing, their action is displayed as "action unknown." I would like to be able to see the actions again.
Title: Re: Who's Online Unknown Action
Post by: Aimee on July 23, 2012, 04:44:38 PM
Uh, no, it's right.  The contents of my Who's Online became pointless until I made the change above.
Title: Re: Who's Online Unknown Action
Post by: avepeachy on July 30, 2012, 04:13:33 PM
I made the change above as well and I am still encountering the same problem of a majority of my members being displayed with unknown action under the Who's Online.
Title: Re: Who's Online Unknown Action
Post by: AngelinaBelle on July 31, 2012, 11:03:21 AM
Aimee -- the code you changed -- is this "pure" SMF code, or is it code SimplePortal modified?
If this is an SMF bug, it really ought to be reported to the SMF devs.  That's why I'd like to find out if it is an SMF bug.

avepeachy -- I think there may be more than one possible cause for the "unknown action" problem you observe. So Aimee's fix may or may not have any affect at all on some or all of your "unknown Actions".

That said, there can always be some "unknown action" in the who list (I see one right here right now, for example).
It's when there are "too many" of them that we suspect a problem.

avepeachy -- you may need to uninstall mods, in the reverse order that you installed them, until you reach the point where things work again.  That will help to narrow down which mod is associated with the problem.

After that, it could be possible to find out if the problem is in the mod or in SMF itself.
Title: Re: Who's Online Unknown Action
Post by: FireDitto on August 16, 2012, 10:52:01 PM
I don't think reverse uninstalling will work for me; my online list was working perfectly well prior to Installing Simple Portal, which is the last mod I have Installed. It is the first time I've installed SP on my forum, and it installed cleanly.

I attempted the change which Aimee put up, and is has brought about no change. The memberlist still reads entirely as "Unknown Action" except in the following instances:

User is viewing the Portal
User is viewing a Page

Guests and Spiders show as viewing topics. It is only the members that are filing as Action Unknown at all times aside from the above mentioned.
Title: Re: Who's Online Unknown Action
Post by: [SiNaN] on August 17, 2012, 10:27:34 AM
Yeah, I may have done something that broke who's online in the last version. I'll look into it soon, as soon as I can.
Title: Re: Who's Online Unknown Action
Post by: FireDitto on August 17, 2012, 10:09:38 PM
Thank you, that would be great. I'm rather fond of that page =)
Title: Re: Who's Online Unknown Action
Post by: Aimee on August 22, 2012, 02:35:35 PM
AngelinaBelle, yes it was SMF code not SP.  It started happening after I upgraded SP however, so there's some type of linkage.
I'll follow up with SMF.
Title: Re: Who's Online Unknown Action
Post by: AngelinaBelle on August 23, 2012, 01:46:21 PM
There may be something "funny" going on. Clearly, "everything" to do with that seems to work OK on SimplePortal.net.  But not on your site.  What is different between the two sites?
Title: Re: Who's Online Unknown Action
Post by: joey791 on September 16, 2012, 11:18:35 PM
SMF 2.0.2 and Simpleportal 2.3.5 and having the same issues

Title: Re: Who's Online Unknown Action
Post by: goodman854 on September 02, 2013, 12:09:57 AM
Massive Bump, Probably breaking forum rules.
I see no reason to make a new topic since it is the exact same issue.

I have confirmed it is in fact Simple Portal.

Using the trick located at: http://www.simplemachines.org/community/index.php?topic=467136.0

I have found that all users that are doing "Unknown Action"
Are now in fact, viewing the portal.
Something is causing this.
Title: Re: Who's Online Unknown Action
Post by: [SiNaN] on September 02, 2013, 04:27:46 PM
It's related to the change related to keeping users online when they are not refreshing any forum page but just using the shoutbox. That change will be reverted in the next version and it should solve the issue.
Title: Re: Who's Online Unknown Action
Post by: goodman854 on September 03, 2013, 06:33:23 AM
It's related to the change related to keeping users online when they are not refreshing any forum page but just using the shoutbox. That change will be reverted in the next version and it should solve the issue.
Ok thank you.

Also just today my forum randomly made it so if I shout in the shout box the whole page refreshes. I don't think I installed anything, I guess someone changed something? Any idea what could have caused that?
Title: Re: Who's Online Unknown Action
Post by: [SiNaN] on January 02, 2014, 06:10:23 PM
For those who are having this problem:

http://simpleportal.net/index.php?topic=13032.msg64784#msg64784
Title: Re: Who's Online Unknown Action
Post by: [SiNaN] on August 14, 2014, 11:16:16 AM
Fixed for the upcoming version.
SimplePortal 2.3.8 © 2008-2024, SimplePortal