SimplePortal

Development => Bugs => Fixed or Bogus Bugs => Topic started by: Aimee on June 22, 2012, 04:49:25 PM

Title: Whispering Colons and Syntax
Post by: Aimee on June 22, 2012, 04:49:25 PM

When using the new shoutbox whisper feature, the colon supplied in existing shouts is Not the colon which the code recognizes as the terminating delimiter.  Maybe it's a utf8 thing. 

So we can't copy and paste Name: from the shoutbox, prepend with with an at-sign, and expect the whisper to work correctly.  We have to actually type the colon, and that confuses people.  Me too.

Thanks,

Title: Re: Whisper Colons
Post by: Aimee on June 22, 2012, 06:28:22 PM

SOLVED.

Forced PCRE to use utf8 check.  Also got rid of the space requirement after the colon since that was messing up some people too.

Subs-portal.php, line 1278 started with

if (preg_match('~^@(.+?):~ ' . ($context['utf8'] ? 'u' : ''), $shout['text'], $target) 

Now

if (preg_match('~^@(.+?):~u', $shout['text'], $target) 

Title: Re: Whispering Colons and Syntax
Post by: AngelinaBelle on June 26, 2012, 07:23:07 PM

Clever.  Thanks for the report.