SimplePortal

Development => Bugs => Fixed or Bogus Bugs => Topic started by: phantomm on September 05, 2012, 03:56:51 PM

Title: Outdated block Top Stats - Advanced Rep System
Post by: phantomm on September 05, 2012, 03:56:51 PM

Block Top stats with Advanced Reputation System (http://custom.simplemachines.org/mods/index.php?mod=1129) is outdated, possible fix: http://simpleportal.net/index.php?topic=11765.msg59848#msg59848

in ./Sources/PortalBlocks.php:

Code: (Find) [Select]

'10' => array(
'name' => 'Advanced Reputation System Best',
'mod_id' => 1129,
'field' => '(mem.karmaGood - mem.karmaBad) AS karma, karmaGood, karmaBad',
'order' => 'karma',
'where' => 'mem.karmaGood > mem.karmaBad',
'output_function' => create_function('&$row', '
global $modSettings;
$descriptions = preg_split("/(\r)?\n/", $modSettings["karmaDescriptions"]);
$rep_bars = "";

$points = $row["karma"];
$bars = ($points - ($points % $modSettings["karmaBarPoints"])) / $modSettings["karmaBarPoints"];
$bars = $bars < 1 ? 1 : (($bars > $modSettings["karmaMaxBars"]) ? $modSettings["karmaMaxBars"] : $bars);
$description = $descriptions[$bars - 1];

for($i = 0; $i < $bars; $i++)
$rep_bars .= \'<img src=\"\' . $settings["images_url"] . "/karmaGood_" . ($i < ($modSettings["karmaSuperBar"] - 1) ? "basic" : "super") . \'.gif" title="\' . $row["realName"] . " " . $description . \'" alt="\' . $row["realName"] . " " . $description . \'" />\';

$row += array(
"reputation_bars" => $rep_bars,
"amount" => "+" . $row["karma"],
);
'),
'output_text' => (!empty($txt['karma_power']) ? $txt['karma_power'] : '') . ': %amount%<br />%reputation_bars%',
'enabled' => !empty($modSettings['karma_enabled']) && file_exists($settings['images_url'] . '/karmaBad_basic.gif'),
'error_msg' => $txt['sp_reputation_no_exist'],
),
'11' => array(
'name' => 'Advanced Reputation System Worst',
'mod_id' => 1129,
'field' => '(karmaBad - karmaGood) AS karma, karmaGood, karmaBad',
'order' => 'karma',
'where' => 'mem.karmaBad > mem.karmaGood',
'output_function' => create_function('&$row', '
global $modSettings;
$rep_bars = "";

$points = $row["karma"];
$bars = ($points - ($points % $modSettings["karmaBarPoints"])) / $modSettings["karmaBarPoints"];
$bars = $bars < 1 ? 1 : (($bars > $modSettings["karmaMaxBars"]) ? $modSettings["karmaMaxBars"] : $bars);
$description = $descriptions[$bars - 1];

for($i = 0; $i < $bars; $i++)
$rep_bars .= \'<img src=\"\' . $settings["images_url"] . "/karmaGood_" . ($i < ($modSettings["karmaSuperBar"] - 1) ? "basic" : "super") . \'.gif" title="\' . $row["realName"] . " " . $modSettings["karmaNegativeDescription"] . \'" alt="\' . $row["realName"] . " " . $modSettings["karmaNegativeDescription"] . \'" />\';

$row += array(
"reputation_bars" => $rep_bars,
"amount" => "-" . $row["karma"],
);
'),
'output_text' => (!empty($txt['karma_power']) ? $txt['karma_power'] : '') . ': %amount%<br />%reputation_bars%',
'enabled' => !empty($modSettings['karma_enabled']) && file_exists($settings['images_url'] . '/karmaBad_basic.gif'),
'error_msg' => $txt['sp_reputation_no_exist'],
),


Code: (Replace with) [Select]

'10' => array(
'name' => 'Advanced Reputation System Best',
'mod_id' => 1129,
'field' => '(mem.karma_good - mem.karma_bad) AS karma, karma_good, karma_bad',
'order' => 'karma',
'where' => 'mem.karma_good > mem.karma_bad',
'output_function' => create_function('&$row', '
global $modSettings, $settings;
$descriptions = preg_split("/(\r)?\n/", $modSettings["karmaDescriptions"]);
$rep_bars = "";

$points = $row["karma"];
$bars = ($points - ($points % $modSettings["karmaBarPoints"])) / $modSettings["karmaBarPoints"];
$bars = $bars < 1 ? 1 : (($bars > $modSettings["karmaMaxBars"]) ? $modSettings["karmaMaxBars"] : $bars);
$description = $descriptions[$bars - 1];

for($i = 0; $i < $bars; $i++)
$rep_bars .= \'<img src="\' . $settings["images_url"] . "/karma_good_" . ($i < ($modSettings["karmaSuperBar"] - 1) ? "basic" : "super") . \'.gif" title="\' . $row["real_name"] . " " . $description . \'" alt="\' . $row["real_name"] . " " . $description . \'" />\';

$row += array(
"reputation_bars" => $rep_bars,
"amount" => "+" . $row["karma"],
);
'),
'output_text' => (!empty($txt['karma_power']) ? $txt['karma_power'] : '') . ': %amount%<br />%reputation_bars%',
'enabled' => file_exists($settings['default_theme_dir'] . '/Karma.template.php'),
'error_msg' => $txt['sp_reputation_no_exist'],
),
'11' => array(
'name' => 'Advanced Reputation System Worst',
'mod_id' => 1129,
'field' => '(karma_bad - karma_good) AS karma, karma_good, karma_bad',
'order' => 'karma',
'where' => 'mem.karma_bad > mem.karma_good',
'output_function' => create_function('&$row', '
global $modSettings, $settings;
$rep_bars = "";

$points = $row["karma"];
$bars = ($points - ($points % $modSettings["karmaBarPoints"])) / $modSettings["karmaBarPoints"];
$bars = $bars < 1 ? 1 : (($bars > $modSettings["karmaMaxBars"]) ? $modSettings["karmaMaxBars"] : $bars);
$description = $descriptions[$bars - 1];

for($i = 0; $i < $bars; $i++)
$rep_bars .= \'<img src="\' . $settings[\'images_url\'] . "/karma_good_" . ($i < ($modSettings["karmaSuperBar"] - 1) ? "basic" : "super") . \'.gif" title="\' . $row["real_name"] . " " . $modSettings["karmaNegativeDescription"] . \'" alt="\' . $row["real_name"] . " " . $modSettings["karmaNegativeDescription"] . \'" />\';

$row += array(
"reputation_bars" => $rep_bars,
"amount" => "-" . $row["karma"],
);
'),
'output_text' => (!empty($txt['karma_power']) ? $txt['karma_power'] : '') . ': %amount%<br />%reputation_bars%',
'enabled' => file_exists($settings['default_theme_dir'] . '/Karma.template.php'),
'error_msg' => $txt['sp_reputation_no_exist'],
),


Title: Re: Outdated block Top Stats - Advanced Rep System
Post by: AngelinaBelle on September 20, 2012, 03:52:59 PM

 
Tracked as issur 468
http://simpleportal.net/index.php?issue=468.0 (http://simpleportal.net/index.php?issue=468.0)

Title: Re: Outdated block Top Stats - Advanced Rep System
Post by: [SiNaN] on August 13, 2014, 05:25:52 PM

Fixed for the upcoming version.