SimplePortal
Customization => Custom Coding => Topic started by: 420connect on February 07, 2015, 07:36:20 AM
-
hello! :)
I downloaded "sp-xtra-shoutbox_options-v1.5x.zip" and went to install but get the following test fails:
if (!empty($_REQUEST['shout']))
if (!empty($count) && $count >= $context['SPortal']['shoutbox']['consecutive'])
$context['SPortal']['shoutbox']['warning'] = str_replace('[#]', $context['SPortal']['shoutbox']['consecutive'], $context['SPortal']['shoutbox']['consecutive_msg']);
elseif (!empty($_REQUEST['shout']) && !$read_only)
and
<li class="smalltext">', !$shout['is_me'] ? '<strong>' . $shout['author']['link'] . ':</strong> ' : '', $shout['text'], '<br />', !empty($shout['delete_link_js']) ? '<span class="shoutbox_delete">' . $shout['delete_link_js'] . '</span>' : '' , '<span class="smalltext shoutbox_time">', $shout['time'], '</span></li>';
<li class="smalltext">', !$shout['is_me'] ? '<strong>' . $shout['author']['link'] . ':</strong> ' : '', '<span style="word-wrap: break-word;overflow-y: auto;overflow-x: hidden;">' . $shout['text'], '</span><br /><span class="shoutbox_delete">', (!empty($shout['edit_link_js']) ? $shout['edit_link_js'] : ' '), (!empty($shout['delete_link_js']) ? $shout['delete_link_js'] : ' '), '</span><span class="smalltext shoutbox_time">', $shout['time'], '</span></li>';
I've already got the colour drop down, shoutbox sound and PM member plugin's installed..
-
[...] Hint: attach the faulty file(s), provide a screeenshot of the failing tests.
Parsing the modifications is ok as well but still missing the files ;D and I don't have the power to fix it without seeing it :P
-
Sorry, I never realised I was being so non-specific to which files..
Okay, I tried manually adding in the code but for whatever reason the package manager wasn't finding:
this part:
if (!empty($_REQUEST['shout']))on ./Sources/PortalShoutbox.php
but I was able to make that change manually.
I'm now just left with the second one that I'm struggling to make manually as it's already been changed by the other plugins.
So I'm looking to combine the 2 of these into one:
I currently have:
<li class="smalltext">', !$shout['is_me'] ? '<strong>' . $shout['author']['link'] . ':</strong> ' : '', '<span style="word-wrap: break-word;overflow-y: auto;overflow-x: hidden;">' . $shout['text'], '</span><br /><span class="shoutbox_delete">',
(!empty($shout['edit_link_js']) ? $shout['edit_link_js'] : ' '), (!empty($shout['delete_link_js']) ? $shout['delete_link_js'] : ' '), '</span><span class="smalltext shoutbox_time">', $shout['time'], '</span></li>';
Package manager wants to find:
<li class="smalltext">', !$shout['is_me'] ? '<strong>' . $shout['author']['link'] . ':</strong> ' : '', $shout['text'], '<br />', !empty($shout['delete_link_js']) ? '<span class="shoutbox_delete">' . $shout['delete_link_js'] . '</span>' : '' , '<span class="smalltext shoutbox_time">', $shout['time'], '</span></li>';
and replace with:
<li class="smalltext">', !$shout['is_me'] ? '<a href="javascript:void(0);" title="'.$txt['sp_shoutbox_pm_title'].'" onclick="document.getElementById(\'new_shout_'. $shoutbox['id']. '\').value=\'@' . $shout['author']['name'] . ': \'">@</a>
<strong>' . $shout['author']['link'] . ':</strong> ' : '', $shout['text'], '<br />', !empty($shout['delete_link_js']) ? '<span class="shoutbox_delete">' . $shout['delete_link_js'] . '</span>' : '' , '<span class="smalltext shoutbox_time">', $shout
['time'], '</span></li>';
(this is in PortalShoutbox.template.php)
updated
-
My php knowledge is not enough to do that so I'd suggest to wait for Chen Zhen or another competent coder for this one :)
-
420connect,
What you currently have (as stated) is what the mod you referenced (sp-xtra-shoutbox_options-v1.5) changes the code to so I do not see you specifically having an issue with my mod. You seem to be having an issue with whatever mod is attempting to add the last bit of code you posted which is not my plug-in.
-
Keep in mind that both those plug-ins will no longer uninstall properly since you are altering the code with manual edits.
find:
<li class="smalltext">', !$shout['is_me'] ? '<strong>' . $shout['author']['link'] . ':</strong> ' : '', '<span style="word-wrap: break-word;overflow-y: auto;overflow-x: hidden;">' . $shout['text'], '</span><br /><span class="shoutbox_delete">', !empty($shout['edit_link_js']) ? $shout['edit_link_js'] : ' '), (!empty($shout['delete_link_js']) ? $shout['delete_link_js'] : ' '), '</span><span class="smalltext shoutbox_time">', $shout['time'], '</span></li>';
replace with:
<li class="smalltext">', !$shout['is_me'] ? '<a href="javascript:void(0);" title="'.$txt['sp_shoutbox_pm_title'].'" onclick="document.getElementById(\'new_shout_'. $shoutbox['id']. '\').value=\'@' . $shout['author']['name'] . ': \'">@</a><strong>' . $shout['author']['link'] . ':</strong> ' : '', '<span style="word-wrap: break-word;overflow-y: auto;overflow-x: hidden;">' . $shout['text'], '</span><br /><span class="shoutbox_delete">', (!empty($shout['edit_link_js']) ? $shout['edit_link_js'] : ' '), (!empty($shout['delete_link_js']) ? $shout['delete_link_js'] : ' '), '</span><span class="smalltext shoutbox_time">', $shout['time'], '</span></li>';
Without knowing exactly which plug-in is displaying the extra link, how it is displayed and with how you posted the code I am not sure if I was supposed to include a space after the @ character, so if it is required just add it.
-
Thank you very much!
that seems to have worked perfectly!
I'm not worried about undoing any of the plugins.
I plan to keep with the Shoutbox now I've found a reliable one :D
I've just noticed actually, when I click the wrench to edit what was said
after what was originally there this is there:
<script type="text/javascript">function spSound(){var beep = document.getElementById("beep");beep.play(1);}</script><object id="beep" type="application/x-shockwave-flash" data="Themes/default/images/sp/shout_sounds.swf" width="0" height="0"><param name="movie" value="Themes/default/images/sp/shout_sounds.swf" /><param name="FlashVars" value="onLoad=spSound" /></object>
-
420connect,
You can use regex to remove the sound effect code and I suppose it is not necessary to add it back again afterwards.
file: ../Sources/PortalEdit.php
find:
$bodyShout = preg_replace('~<div id="edit_shout_' . $shout_id . '" style="display: inline;">(.*?)</div>(?!\s*<div id="edit_shout_' . $shout_id . '" style="display: inline;">)~', '', $bodyShout);
add after above code (next line):
$bodyShout = preg_replace('~<script type="text/javascript">function spSound(){var beep = document.getElementById("beep");beep.play(1);}</script><object id="beep" type="application/x-shockwave-flash" data="Themes/default/images/sp/shout_sounds.swf" width="0" height="0"><param name="movie" value="Themes/default/images/sp/shout_sounds.swf" /><param name="FlashVars" value="onLoad=spSound" /></object>~', '', $bodyShout);
If that does not work properly then I will have to test it myself as I have not done so. Please let me know how that works.
Regards.
-
420connect,
You can use regex to remove the sound effect code and I suppose it is not necessary to add it back again afterwards.
file: ../Sources/PortalEdit.php
find:
$bodyShout = preg_replace('~<div id="edit_shout_' . $shout_id . '" style="display: inline;">(.*?)</div>(?!\s*<div id="edit_shout_' . $shout_id . '" style="display: inline;">)~', '', $bodyShout);
add after above code (next line):
$bodyShout = preg_replace('~<script type="text/javascript">function spSound(){var beep = document.getElementById("beep");beep.play(1);}</script><object id="beep" type="application/x-shockwave-flash" data="Themes/default/images/sp/shout_sounds.swf" width="0" height="0"><param name="movie" value="Themes/default/images/sp/shout_sounds.swf" /><param name="FlashVars" value="onLoad=spSound" /></object>~', '', $bodyShout);
If that does not work properly then I will have to test it myself as I have not done so. Please let me know how that works.
Regards.
That add in worked perfectly, thank you very much!
*e-hugs*
-
sorry, after further testing it appears, the shoutbox isn't updating as it should now :S
a: smftest
pw: smftest
@ 420connect.co.uk
if you'd like to test.
I need to post then refresh to see what I just typed or see new replies.
Surely I can't be the first person to want to combine all the plugins for the shoutbox? :-X
-
Surely I can't be the first person to want to combine all the plugins for the shoutbox? :-X
I'll get there as well :P I already have 135+ mods, all SP plugins can't be missing ;D
The account you provided doesn't have the permission to write in the shoutbox since I couldn't find the relative input field... LOL
-
420connect,
The refresh rate of the shoutbox should be set to ie. 10 or 12 seconds for it to function properly using this plug-in.
-
Hmm, strange..
I've just discovered one of the recent changes must have had an unexpected effect.
whilst I'm still able to see the inputbox/shout button etc. as admin
these are missing for regular users although they should be able to see it? :S
My refresh rate is set to 12 secs and correct permissions set for use/view of shoutbox.
:X
(off to work now but I'll attach any files that could be related when I get back!)
many thanks!
-
Since getting in, I've uninstalled all portal related MOD's/plugins then reinstalled SimplePortal alone.
This has at least fixed the ability to post / have it show fault.
I think I'll hang on until someone who knows what their doing tries out the shoutbox with all avail. plugins :P
-
420connect,
The options plugin adds extra permissions from within your membergroup permission settings for the shoutbox. These must be enabled/disabled for your various membergroups depending on what you want to allow them to do.
-
Hello,
firstly thank you for your replies!
(I'll update the thread title to something more appropriate now this has changed.)
Since removing all the extras I've tried adding the extra options plugin and can now see the "extra options"
I'm able to install the 'colours' mod with no problems as well as the 'options' mod but both the 'PM' mod & 'Sounds' mod have fails.
Would anyone mind trying the combination on their test site if possible and sharing a fix to have them all work smoothly, I'd be super thankful and sure others would like to be able to add these features together too.
-
420connect,
For the shout sounds I was going to write that into the next version of the options mod and for the other plug-ins you are using it would be better for me to also possibly add them to the same plug-in. A link for PM's and membergroup coloured user names is fairly straight forward as far as coding goes. Hopefully I may have time to do this within the next week or so. This will eliminate your need to use more than the single plug-in for all those options.
Regards.
-
420connect,
For the shout sounds I was going to write that into the next version of the options mod and for the other plug-ins you are using it would be better for me to also possibly add them to the same plug-in. A link for PM's and membergroup coloured user names is fairly straight forward as far as coding goes. Hopefully I may have time to do this within the next week or so. This will eliminate your need to use more than the single plug-in for all those options.
Regards.
I second that thing a LOT, thanks VERY much dude! Your help is always much appreciated. A fully modded SP is exactly what I want, yet it's pretty hard to combine everything to make it work properly so it would be truly awesome.
-
420connect,
For the shout sounds I was going to write that into the next version of the options mod and for the other plug-ins you are using it would be better for me to also possibly add them to the same plug-in. A link for PM's and membergroup coloured user names is fairly straight forward as far as coding goes. Hopefully I may have time to do this within the next week or so. This will eliminate your need to use more than the single plug-in for all those options.
Regards.
Hi Chen!
Thank you very much again for the reply and that would be ideal! - You're a star! :angel:
Excitedly awaiting options v2! :)
-
Just wondering you have had a chance to play around with this yet?
Many thanks