SimplePortal

Development => Bugs => Topic started by: Rupurudu! on April 28, 2015, 09:18:17 PM

Title: Shoutbox messages counter is not unsigned.
Post by: Rupurudu! on April 28, 2015, 09:18:17 PM: Maximum allowed shouts (num_max) and Current shoutbox messages (num_shouts) on the smf_sp_shoutboxes table are not set to Unsigned.

Since these values will never be negative, I think making them will both help people who want to set a highier maximum messages, and will help avoiding errors incase if some stupid error who tries to make them negative
Title: Re: Shoutbox messages counter is not unsigned.
Post by: [SiNaN] on August 01, 2015, 06:18:45 AM: I think we never bothered with this because we never hit that limit and SMF's handling of that property was not stable. Thank you for the report. This should be set properly for all relevant fields in the next version.
Title: Re: Shoutbox messages counter is not unsigned.
Post by: [SiNaN] on August 08, 2015, 10:07:13 AM: The fix for this has been committed.
Title: Re: Shoutbox messages counter is not unsigned.
Post by: ♦ Ninja ZX-10RR ♦ on August 08, 2015, 10:48:49 AM: Quote from: [SiNaN] on August 08, 2015, 10:07:13 AM
The fix for this has been committed.
Got any links? My update will be a pain, it's better if I get rid of all the small things ;)
Title: Re: Shoutbox messages counter is not unsigned.
Post by: [SiNaN] on August 08, 2015, 10:52:31 AM: The changes are in the GitHub repo. However, it will only affect the new installations. I haven't coded the database upgrade script yet. That's the last thing I'm going to do.
Title: Re: Shoutbox messages counter is not unsigned.
Post by: ♦ Ninja ZX-10RR ♦ on August 08, 2015, 10:54:02 AM: I'm really undecided whether to try to update manually or reinstall, but reinstalling will definitely be a pain, due to how much work I have done, very unsure :/
Title: Re: Shoutbox messages counter is not unsigned.
Post by: [SiNaN] on August 08, 2015, 11:01:43 AM: For 2.4, I'm pretty sure you'll have to re-install. There are so many changes and there will be a lot more.
Title: Re: Shoutbox messages counter is not unsigned.
Post by: ♦ Ninja ZX-10RR ♦ on August 08, 2015, 11:15:56 AM: I'm scared >_< I really hope you won't change css classes though, as it would be a nightmare for me.