SimplePortal

Development => Bugs => Fixed or Bogus Bugs => Topic started by: AngelinaBelle on August 11, 2009, 12:56:03 PM

Title: New Pages -- text box 1 char wide (SMF 1.1.10)
Post by: AngelinaBelle on August 11, 2009, 12:56:03 PM

Browser: IE
SMF 1.1.10
SMF default theme -- core
SimplePortal 2.3 RC1
 
I just tried out the new 2.3 RC1 in a clone of my "live" forum. After uninstalling and installing the new, I set off to exercise some features.
 
For page type BBC, the text box is a reasonable width.
But for page type HTML or PHP, the text box is initially only 1 char wide.
 
If I add some text and hit the "preview" button, the box gets a little wider to accomodate the text, up to some limit imposed by the style (I guess) and the browser window width.
 
So far, I haven't figured out how to actually SEE any of the pages, but that's a different matter.
 
Here's what I have installed:
 
1. ssi_grabMessage 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
2. Aeva ~ Auto-Embed Video & Audio 6.9.99   [ Uninstall ] [ List Files ] [ Delete ] 
3. Colorized Membergroups 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
4. Custom Profile Field Mod 3.20   [ Uninstall ] [ List Files ] [ Delete ] 
5. PDF Tag 1.1   [ Uninstall ] [ List Files ] [ Delete ] 
6. Custom BBCode 2.00   [ Uninstall ] [ List Files ] [ Delete ] 
7. SMF 1.0.17 / 1.1.9 / 2.0 RC1 Update 1.0   [ List Files ] [ Delete ] 
8. SMF 1.0.18 / 1.1.10 / 2.0 RC1-2 Update 1.0   [ Uninstall ] [ List Files ] [ Delete ] 
9. SimplePortal 2.3 RC1   [ Uninstall ] [ List Files ] [ Delete ]

Title: Re: New Pages -- text box 1 char wide (SMF 1.1.10)
Post by: ???1031 on August 12, 2009, 05:34:56 AM

I can confirm this with IE7.
Happen only on SMF 1.1.x

$themedir/PortalAdminPages.template.php

Code: (Search for) [Select]

<table>
', theme_postbox($context['SPortal']['page']['body']), '
</table>


Code: (Replace with) [Select]

<table width="90%">
', theme_postbox($context['SPortal']['page']['body']), '
</table>

Currently the only way i know how to make it work correct ;).

Title: Re: New Pages -- text box 1 char wide (SMF 1.1.10)
Post by: AngelinaBelle on August 12, 2009, 08:29:21 AM

That does seem like a good quick fix. Thanks.
 
Good point about the browser!
I DO NOT see this problem in IE8.
I DO see this problem in IE8, in compatability mode.
 
This arises, I think, from shoving theme_post down into a <td><table> instead of directly in the table body, to allow for the <th>Body:</th> heading, which SMF (1.x or 2.x) does not use in postings.
 
In a Topic post, the first <td /> in each row output by theme_post lines up with <td...>Subject:</td>, etc., on a post, and the <td...><textarea name="body" ...></td> lines up with <td...><textarea name="subject">, and the table width has already been set to 100%
 
But that doesn't happen with the theme_post output in a <table> in a <td> instead of directly in the table body. And IE7 doesn't seem think that it is important for <textarea ... columns=60> to be given any consideration for its width.
 
So I guess this one could be categorized as "not tested with IE7".
 
Thanks -- it would have taken me quite a long time to work my way through the code to find where that HTML comes from. I still haven't figured out where function theme_post is found!
 
AB

Title: Re: New Pages -- text box 1 char wide (SMF 1.1.10)
Post by: [SiNaN] on August 12, 2009, 09:15:38 AM

http://simpleportal.net/index.php?issue=241.0

Title: Re: New Pages -- text box 1 char wide (SMF 1.1.10)
Post by: AngelinaBelle on August 17, 2009, 12:21:45 PM

Thanks. 
 
theme_postbox, of course.  I just discovered http://support.simplemachines.org/function_db/index.php?action=main (http://support.simplemachines.org/function_db/index.php?action=main)
 
What a great resource for finding those pesky functions!
 
I'm a noob :)