SimplePortal

Development => Feature Requests => Topic started by: MissyNL on October 06, 2009, 06:41:28 PM

Title: Whisper mode in Shoutbox
Post by: MissyNL on October 06, 2009, 06:41:28 PM
Hello,

I would like to see a whisper mode in the shoutbox. I am running a dating orientated site and i know the members would love it.

That they can search a name an that that person only can see it. I have seen a demo, but then the admin also could see it. Maybe that is also a good option...


Title: Re: Whisper mode in Shoutbox
Post by: Nathaniel on October 06, 2009, 07:34:41 PM
Seems like a good suggestion, I have added it to the Project Tracker, although its unlikely to be added until the next major release of SimplePortal.

Project tracker issue: http://simpleportal.net/index.php?issue=285.0
Title: Re: Whisper mode in Shoutbox
Post by: Eliana Tamerin on October 06, 2009, 07:43:18 PM
It probably would work to follow a Twitter-like @username scheme.
Title: Re: Whisper mode in Shoutbox
Post by: [SiNaN] on October 07, 2009, 05:14:39 AM
Hey MissyNL! I hope you are doing fine. Converting to SimplePortal?

This one is pretty easy.

Sources/Subs-Portal.php

Code: (Find) [Select]
$shouts[$shout['id']] += array(
Code: (Replace) [Select]
if (preg_match('~^@([^:]+):.+~' . ($context['utf8'] ? 'u' : ''), $shout['text'], $target) && $smcFunc['strtolower']($target[1]) !== $smcFunc['strtolower']($user_info['name']) && $shout['author']['id'] != $user_info['id'] && !$user_info['is_admin'])
{
unset($shouts[$shout['id']]);
continue;
}

$shouts[$shout['id']] += array(

Syntax would be like this:

Quote
@{user_name}: {shout_text}

Example:

Quote
@MissyNL: This is special for you!

Note that username is case insensitive.
Title: Re: Whisper mode in Shoutbox
Post by: Eliana Tamerin on October 07, 2009, 09:28:57 AM
Sinan, Nath and I talked about this for a while, and I suggested that very setup. Problem is, SMF accepts colons (:) in usernames, so if you have a user named MissyNL: This (unlikely, but you see what I mean), it's going to screw up.

The bugtracker issue has a few comments related to how we might work around that issue, including
Quote
@"user name" message
and
Quote
@user=name message

but of course, a one word username would just be like:
Quote
@username message
So that SP would always know what to look for, and find the username that was contained within the @ and the next space.

To ensure that usernames are matched 100% of the time.
Title: Re: Whisper mode in Shoutbox
Post by: [SiNaN] on October 07, 2009, 12:25:35 PM
Both double quotes and equal sign can be used in usernames as well. Thus they won't be any different. It is the natural limitation of this function, just like you can't link my profile using my username with wiki links. And @username: format looks more semantic to me. I wouldn't add alternative formats for unusual usernames as well; that just complicates things further.
Title: Re: Whisper mode in Shoutbox
Post by: Nathaniel on October 07, 2009, 05:54:58 PM
Both double quotes and equal sign can be used in usernames as well. Thus they won't be any different. It is the natural limitation of this function, just like you can't link my profile using my username with wiki links. And @username: format looks more semantic to me. I wouldn't add alternative formats for unusual usernames as well; that just complicates things further.

Actually, double quotes and the equals sign cannot be used within usernames. Refer to the 'Subs-Members.php' file. (line 627 for SMF 1.1.10, line 507 for SMF 2 RC1.2)

These are the restricted characters: < > & " ' = \
Title: Re: Whisper mode in Shoutbox
Post by: Eliana Tamerin on October 07, 2009, 05:59:49 PM
Actually the single quote (') is just fine. I think its presence there has something to do with the regex used.
Title: Re: Whisper mode in Shoutbox
Post by: [SiNaN] on October 08, 2009, 03:59:13 AM
That's member name. Display name (real name) has no limitations; it will accept anything and everything. That's what a regular member see as username. And I'm not arguing how it should be handled in core; just provided a custom code which I believe is the proper way.
Title: Re: Whisper mode in Shoutbox
Post by: Robbo on October 08, 2009, 11:21:32 AM
Errr, it can work by looking for the last :. Or a : then space. Anyways you think something like this will make it into the next version Nathan?
Title: Re: Whisper mode in Shoutbox
Post by: MissyNL on October 08, 2009, 11:38:16 AM
Hi Sinan! Good to see/read you again! :)  I am doing fine and the mods you developed for me are working like a charm! They are very much appreciated by my members.

Yes... i am going to convert to SP :) My whole site is going to be converted in 2.0. But that can take a while, since i have over 60 mods now LOL
Luckely i have the help form Robbo (http://www.bimeiden.nl/Smileys/default/smiley_egyptian.gif)

It's great that there is such a huge responds to this request. (http://www.bimeiden.nl/Smileys/default/cheer.gif)

I only understand the halve of what you are saying :lol The thing i only have to say.. make it so that members do not have to type in the name. This because the message that will be displayed is personal en sensitive. If the member will do it wrong (which they will do) i have a good possibility that all hell brakes lose.

If that can not be done.. then it's maybe better to skip this request, since it then can cause more harm then good (in by situation then)


Title: Re: Whisper mode in Shoutbox
Post by: Nathaniel on October 08, 2009, 05:40:55 PM
That's member name. Display name (real name) has no limitations; it will accept anything and everything. That's what a regular member see as username. And I'm not arguing how it should be handled in core; just provided a custom code which I believe is the proper way.

Sigh, true. "@username: message" is the most semantic then. Hopefully no-one has usernames with a colon in them. ;)

Errr, it can work by looking for the last :. Or a : then space. Anyways you think something like this will make it into the next version Nathan?

It will definetly make it into 2.4, not sure about 2.3.1 as its meant to only be a bugfix release. Not that that doesn't mean we can't add small features, but that I want to release it as soon as possible.

I only understand the halve of what you are saying :lol The thing i only have to say.. make it so that members do not have to type in the name. This because the message that will be displayed is personal en sensitive. If the member will do it wrong (which they will do) i have a good possibility that all hell brakes lose.

If that can not be done.. then it's maybe better to skip this request, since it then can cause more harm then good (in by situation then)

If the user made a typo, and put in the wrong username then it would either send it to the wrong user, or it wouldn't work properly.

There are possibilities of things that can be done to avoid that, like:
- A dropdown box of usernames (using javascript). Ie, you type in 'Tes' and it gives you a list of the possible usernames like 'Tesla', 'Test', etc.
- A whisper link/icon next to each shout, which adds the correct username to the shout area.
- A 'whisper' popup, that makes you enter the username and then checks that it exists.
Title: Re: Whisper mode in Shoutbox
Post by: Eliana Tamerin on October 08, 2009, 06:10:14 PM
Well, it also follows that this isn't meant for private or sensitive conversations. Just a way to secretly shout to a user. So if users are using that to transmit sensitive information, that's the risk they take.
Title: Re: Whisper mode in Shoutbox
Post by: MissyNL on October 08, 2009, 06:58:52 PM
Quote
- A dropdown box of usernames (using javascript). Ie, you type in 'Tes' and it gives you a list of the possible usernames like 'Tesla', 'Test', etc.
  I think i like this option :D

Well, it also follows that this isn't meant for private or sensitive conversations. Just a way to secretly shout to a user. So if users are using that to transmit sensitive information, that's the risk they take.

I completely understand what you are saying. The thing only is that on my site the changes of sending a personal or sensitive message is quit high, since i have a dating site where people like to provoke another.. in a good way  ;D  The problem is that most of my members are not so good with understanding some features on the site or even the whole structure of the site. I have to explain all the features in detail.

This means that the changes of people filling in the wrong name are relatively high. Resulting in the whispermode not being used often and the occasional embarrassment of the member.

If the SP-team makes the code in a way where members have to fill in the membername entirely, then maybe the SP-team should consider an option where admins can disable the whisper mode.
Title: Re: Whisper mode in Shoutbox
Post by: Robbo on October 11, 2009, 12:00:43 PM
Maybe do it like private messages?
Title: Re: Whisper mode in Shoutbox
Post by: Nathaniel on October 11, 2009, 04:48:26 PM
If the SP-team makes the code in a way where members have to fill in the membername entirely, then maybe the SP-team should consider an option where admins can disable the whisper mode.

It would definitely have an option to remove whispers.

Maybe do it like private messages?

Not sure exactly what you mean by that.
Title: Re: Whisper mode in Shoutbox
Post by: MissyNL on October 12, 2009, 06:09:05 AM
i think he means like making it like filling in the username in the PM. That it auto fills itselve.. and that you can click the questionmark and then search the name yourself it the autofill doesnt work properly...

Correct me if im wrong :D
Title: Re: Whisper mode in Shoutbox
Post by: Nathaniel on October 12, 2009, 06:21:54 AM
i think he means like making it like filling in the username in the PM. That it auto fills itselve.. and that you can click the questionmark and then search the name yourself it the autofill doesnt work properly...

Correct me if im wrong :D

True, I had forgotten about that, I suppose it fits in quite naturally to the page. :)

I will think about that when I implement this feature.
Title: Re: Whisper mode in Shoutbox
Post by: MissyNL on May 11, 2010, 09:13:42 AM
Great to know this feature will come in the next edition :D
Title: Re: Whisper mode in Shoutbox
Post by: Sir Kaos on November 13, 2010, 03:23:38 AM
it would be great news if you guys implement this.

lets hope so  ;)
Title: Re: Whisper mode in Shoutbox
Post by: MissyNL on December 13, 2010, 08:30:31 AM
any update about this request?
Title: Re: Whisper mode in Shoutbox
Post by: Sir Kaos on December 20, 2010, 04:01:35 AM
i am watching this thread. eagerly waiting for this release. Private chat in my forum shoutbox is something very important. waited for 2 months now and still havent launched the forum itself because of this  ;D

but cant wait any longer. Will launch it and as soon as its done hopefully, will upgrade.
Title: Re: Whisper mode in Shoutbox
Post by: kran4141 jambodada on December 20, 2010, 08:32:04 AM
Thanks for this information. It really helped me a lot.
Title: Re: Whisper mode in Shoutbox
Post by: MissyNL on July 26, 2012, 05:48:10 AM
Hi There... have read that the whisper mode is now implemented... How great!!

How do i do "whisper" in the shoutbox? with a @ or something?
Title: Re: Whisper mode in Shoutbox
Post by: phantomm on July 26, 2012, 12:13:28 PM
@User: message
example:

@phantomm: this is message
Title: Re: Whisper mode in Shoutbox
Post by: MissyNL on July 26, 2012, 04:49:53 PM
hmm.. i have done that.. but the text appear as normal. So how do you you know that it is in whisper mode?
Title: Re: Whisper mode in Shoutbox
Post by: phantomm on July 26, 2012, 05:04:44 PM
logout and check it as guest or another user?
Title: Re: Whisper mode in Shoutbox
Post by: MissyNL on July 30, 2012, 05:58:47 AM
tried it... and it doesnt work :(
Title: Re: Whisper mode in Shoutbox
Post by: phantomm on July 30, 2012, 06:04:29 AM
Then I suggest you make new topic with this problem in support board (and add there more details: SMF version, SP version), because this is for Feature Requests ;)

http://simpleportal.net/index.php?board=11.0
Title: Re: Whisper mode in Shoutbox
Post by: MissyNL on August 12, 2012, 03:41:01 PM


The reason why i posted in this block is because this feature was a request of mine... But thanks! Will do :D
SimplePortal 2.3.8 © 2008-2024, SimplePortal