SimplePortal

Development => Bugs => Fixed or Bogus Bugs => Topic started by: ccbtimewiz on November 19, 2010, 03:00:21 AM

Title: Using SSI for Polls?
Post by: ccbtimewiz on November 19, 2010, 03:00:21 AM

Refer to this line in ./Sources/PortalBlocks.php

Code: [Select]

<form action="', $boardurl, '/SSI.php?ssi_function=pollVote" method="post" accept-charset="', $context['character_set'], '">
As you can see you're using a function inside of SSI.php to do votes. Is there any particular reason for this? Wouldn't it be the *right* thing to make the query inside of the function and do it from there instead of relying on an SSI function?

What if the admin deleted SSI because it was unnecessary?

Title: Re: Using SSI for Polls?
Post by: Nathaniel on November 19, 2010, 08:03:17 AM

Several of the blocks rely on the SSI.php file and its functions. This is by purpose. SimplePortal will not work properly if the SSI.php file is not there. As it is a default part of SMF, it is hardly unreasonable to expect that file to exist.

This is hardly a bug, rather a question of coding style. Its pointless to recode that functionality that is already provided by the SSI.php file, so we haven't.

Moving to the bogus bugs board.

Title: Re: Using SSI for Polls?
Post by: Masterd on January 17, 2011, 03:47:15 PM

Yes, SSI.php is a part of SMF and everyone is useing it.