Main Menu
collapse

Simple Portal Archived Forum

This is an Archive Forum.

The content in this forum may be out-of-date or have been superseded by newer information, and links in forum pages to other sites may not work.
This forum contains archives for future reference.

Visit our thread at Simple Machines Forum for current support.

SMF 2.1 users: EhPortal is a ported version of Simple Portal specifically designed for the SMF 2.1 branch.
Please visit web-develop.ca to download EhPortal and for its support.

User Info

Welcome Guest.
Please log in.

Who's Online

  • Dot Guests: 1141
  • Dot Hidden: 0
  • Dot Users: 0

There aren't any users online.

Recent Posts

Adding Forums Button to Nav bar by jirapon
[August 01, 2019, 09:07:12 AM]


Re: Board Icons by ♦ Ninja ZX-10RR ♦
[July 30, 2019, 04:03:41 PM]


MOVED: Czech translation???? by ♦ Ninja ZX-10RR ♦
[July 30, 2019, 03:04:51 PM]


Board Icons by jirapon
[July 30, 2019, 07:28:44 AM]


Re: Thankyou Simpleportal, by ♦ Ninja ZX-10RR ♦
[July 29, 2019, 09:41:29 AM]


NEED HELP? If you're looking for support with Simple Portal, look no further than the Support Board!

shoutbox @ fix not working on my site

Started by steve51184, March 10, 2010, 05:44:43 AM

Previous topic - Next topic

0 Members and 3 Guests are viewing this topic.

steve51184


[SiNaN]

Well, the problem is, I'm unable to reproduce the problem you are having. Any chance I can debug it myself? I will need a temporary FTP access only.
And slowly, you come to realize... It's all as it should be...

steve51184

could i not give you all the files you need but in .tar/.zip archive or something as i don't have ftp installed on my server

(i'm an scp man not and ftp man :P)

[SiNaN]

Okay, all files in Sources and Themes directories + index.php would be enough.
And slowly, you come to realize... It's all as it should be...

steve51184

Quote from: [SiNaN] on March 10, 2010, 06:07:28 AM
Okay, all files in Sources and Themes directories + index.php would be enough.

pm sent ;)

[SiNaN]

Okay. I could reproduce it but will check it later. Need to do my homework first.
And slowly, you come to realize... It's all as it should be...


MultiformeIngegno


steve51184

Quote from: [SiNaN] on March 10, 2010, 06:20:03 AM
Okay. I could reproduce it but will check it later. Need to do my homework first.

any news on this?

steve51184

come on guys i've been waiting over a month for a fix now... i understand that your busy but i need help with this!

[SiNaN]

I'm sorry. This is one of few issues I can't offer a solution without examining the code.

I tried it again and now can't reproduce it even with your files. I'll let Nath check this one as well.

Also, are you sure that you correctly replaced your Subs.php file with this one and it didn't work?
And slowly, you come to realize... It's all as it should be...

steve51184

Quote from: [SiNaN] on March 14, 2010, 12:07:02 PM
I'm sorry. This is one of few issues I can't offer a solution without examining the code.

I tried it again and now can't reproduce it even with your files. I'll let Nath check this one as well.

Also, are you sure that you correctly replaced your Subs.php file with this one and it didn't work?

VERY sure... i install ALL smf mods by hand and have done for years so i know how to make edits 8)

also is there not just an easy was to disable email addresses being posted in the shoutbox?

[SiNaN]

I'm saying that because the original Subs.php file you attached had the first edit applied but not the second edit.

This issue is actually fixed with SMF 2.0 RC3. But to prevent e-mail address being parsed in shoutbox, this should be enough:

Code (Find) Select
'text' => parse_bbc($row['body'], true, '', $bbc),

Code (Replace) Select
'text' => parse_bbc(str_replace('@', '[at]', $row['body']), true, '', $bbc),
And slowly, you come to realize... It's all as it should be...

steve51184

Quote from: [SiNaN] on March 15, 2010, 02:32:25 PM
I'm saying that because the original Subs.php file you attached had the first edit applied but not the second edit.

This issue is actually fixed with SMF 2.0 RC3. But to prevent e-mail address being parsed in shoutbox, this should be enough:

Code (Find) Select
'text' => parse_bbc($row['body'], true, '', $bbc),

Code (Replace) Select
'text' => parse_bbc(str_replace('@', '[at]', $row['body']), true, '', $bbc),

is that in subs.php as i don't want to disable them for the whole forum

[SiNaN]

Opps, sorry. It's in Subs-Portal.php. It will only affect shouts in the shoutbox.
And slowly, you come to realize... It's all as it should be...

steve51184


[SiNaN]

Regarding this issue, to quote myself from Beta Development board:

Quote from: [SiNaN] on March 17, 2010, 01:28:40 PM
Okay, I've found the issue. It was related to how SMF handles $disabled variable and how PHP handled static variables. Here is the fix:

Code (Find) Select
$default_disabled = $disabled;

Code (Replace) Select
$default_disabled = isset($disabled) ? $disabled : array();

When all tags are enabled, $disabed variable is not set by SMF, thus $default_disabed is not set until it reaches to shout parsing. At that point, $default_disabled is set according to shoutbox settings. I expected $disabled to throw out an error if it wasn't set, but looks like PHP initializes static variables as NULL, so it didn't cause an error, which made it quite difficult to find, especially if you don't allow all BBC tags.

Thanks goes to AngelinaBelle for detailed report on the issue and allowing me to investigate the issue on her forum.
And slowly, you come to realize... It's all as it should be...

MultiformeIngegno

Awesome news! Have you submitted it to mantis? :)

[SiNaN]

It's already fixed in our latest dev package.
And slowly, you come to realize... It's all as it should be...

MultiformeIngegno

Yes yes.. I was only wondering if it was an smf or sp bug.. if is the first you can add it to the mantis tracker at sm.org