Main Menu
collapse

Simple Portal Archived Forum

This is an Archive Forum.

The content in this forum may be out-of-date or have been superseded by newer information, and links in forum pages to other sites may not work.
This forum contains archives for future reference.

Visit our thread at Simple Machines Forum for current support.

SMF 2.1 users: EhPortal is a ported version of Simple Portal specifically designed for the SMF 2.1 branch.
Please visit web-develop.ca to download EhPortal and for its support.

User Info

Welcome Guest.
Please log in.

Who's Online

  • Dot Guests: 1127
  • Dot Hidden: 0
  • Dot Users: 0

There aren't any users online.

Recent Posts

Adding Forums Button to Nav bar by jirapon
[August 01, 2019, 09:07:12 AM]


Re: Board Icons by ♦ Ninja ZX-10RR ♦
[July 30, 2019, 04:03:41 PM]


MOVED: Czech translation???? by ♦ Ninja ZX-10RR ♦
[July 30, 2019, 03:04:51 PM]


Board Icons by jirapon
[July 30, 2019, 07:28:44 AM]


Re: Thankyou Simpleportal, by ♦ Ninja ZX-10RR ♦
[July 29, 2019, 09:41:29 AM]


If you're interested in helping other members with support requests, consider joining the Community Support Helpers group.

Javascript in HTML Block

Started by cyber-burn, June 05, 2010, 09:44:05 AM

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

cyber-burn

Good Morning,

I am working on a HTML block with javascript, and the javasript will run fine when previewing the block, but does not run when the block is shown in the portal?  I believe it has something to do with the way I am calling the function on the load of the body HTML tag, bug I'm not sure.  Any help would be appreciated  :nervous-happy:

Nathaniel

Could you post the code that you are trying to use?
SMF Friend (Former Support Specialist) | SimplePortal DeveloperMy SMF Mods | SimplePortal"Quis custodiet ipsos custodes?" - Who will Guard the Guards?Please don't send me ANY support related PMs. I will just delete them.

cyber-burn

<SCRIPT LANGUAGE="JavaScript">
<!-- Begin
var interval = 2; // delay between rotating images (in seconds)
var random_display = 0; // 0 = no, 1 = yes
interval *= 1000;

var image_index = 0;
image_list = new Array();
image_list[image_index++] = new imageItem
("http://www.reefersparadise.com/POTM/POTM1.jpg");
image_list[image_index++] = new imageItem("http://www.reefersparadise.com/POTM/POTM2.jpg");

var number_of_image = image_list.length;
function imageItem(image_location) {
this.image_item = new Image();
this.image_item.src = image_location;
}
function get_ImageItemLocation(imageObj) {
return(imageObj.image_item.src)
}
function generate(x, y) {
var range = y - x + 1;
return Math.floor(Math.random() * range) + x;
}
function getNextImage() {
if (random_display) {
image_index = generate(0, number_of_image-1);
}
else {
image_index = (image_index+1) % number_of_image;
}
var new_image = get_ImageItemLocation(image_list[image_index]);
return(new_image);
}
function rotateImage(place) {
var new_image = getNextImage();
document[place].src = new_image;
var recur_call = "rotateImage('"+place+"')";
setTimeout(recur_call, interval);
}
//  End -->
</script>

<BODY OnLoad="rotateImage('rImage')">

<center>
<A HREF="http://www.reefersparadise.com/smf/index.php/board,86.0.html">
<img name="rImage" src="http://www.reefersparadise.com/POTM/POTM1.jpg" width=180 height=180 alt="Click here to enter this months POTM Contest."></A>
<font face="Comic Sans MS" size="2">Congrats to our POTM Winners <br>Chris and Oldsaint!</font></center>

</BODY>


This is the code I'm using at the moment.  Just a standard Javascript image rotation code.  Seems to work find when previewing the block, but does not work when the block is in place.  Thanks for taking a look!

This is the code I'm trying to use.  Just a standard javascript image rotator.  The non-functioning block ca

Nathaniel

Why are you using a "body" tag within a block?

That code had several issues, although it worked fine for me when previewing and when viewing on the main page.

The code below fixes some of the more blatant html errors (like using a deprecated center tag and using the body tag).

<script language="JavaScript">
<!-- Begin
var interval = 2; // delay between rotating images (in seconds)
var random_display = 0; // 0 = no, 1 = yes
interval *= 1000;

var image_index = 0;
image_list = new Array();
image_list[image_index++] = new imageItem("http://www.reefersparadise.com/POTM/POTM1.jpg");
image_list[image_index++] = new imageItem("http://www.reefersparadise.com/POTM/POTM2.jpg");

var number_of_image = image_list.length;
function imageItem(image_location) {
this.image_item = new Image();
this.image_item.src = image_location;
}
function get_ImageItemLocation(imageObj) {
return(imageObj.image_item.src)
}
function generate(x, y) {
var range = y - x + 1;
return Math.floor(Math.random() * range) + x;
}
function getNextImage() {
if (random_display) {
image_index = generate(0, number_of_image-1);
}
else {
image_index = (image_index+1) % number_of_image;
}
var new_image = get_ImageItemLocation(image_list[image_index]);
return(new_image);
}
function rotateImage(place) {
var new_image = getNextImage();
document[place].src = new_image;
var recur_call = "rotateImage('"+place+"')";
setTimeout(recur_call, interval);
}
//  End -->
</script>

<div style="text-align: center;">
<a href="http://www.reefersparadise.com/smf/index.php/board,86.0.html">
<img name="rImage" id="rImage" src="http://www.reefersparadise.com/POTM/POTM1.jpg" width=180 height=180 alt="Click here to enter this months POTM Contest.">
</a><br />
<font face="Comic Sans MS" size="2">Congrats to our POTM Winners <br>Chris and Oldsaint!</font>
</div>

<script language="javascript">
rotateImage('rImage');
</script>
SMF Friend (Former Support Specialist) | SimplePortal DeveloperMy SMF Mods | SimplePortal"Quis custodiet ipsos custodes?" - Who will Guard the Guards?Please don't send me ANY support related PMs. I will just delete them.

cyber-burn

Thank you for your help.  Looks like I need to pay more attention when re-using old code.