Topic: Borders on blocks..

[johncccccc]

In my recent coding madness, I have finally replicated a theme to match my old BETA 4, way out of data one, for RC3, with that done, I think Im ready to upgrade.

I having issues replicating the borders on SP blocks and they have scrollers on the right side...

I have used a test forum, with my theme, and copied a very recent backup of my current database, all my blocks are restored on test forum, all settings are applied, so no problems there.

My old theme:
The blocks are using the " .tborder " class, but not in RC3

Any Ideas?

SMF version 2.0 RC3
SP latest 2.3.2

[Nathaniel]

If you have upgrade your theme to work with RC3, but you are still using the xhtml/css methods from before RC2 (which I suspect you are), then you may want to consider making the edit below:

Code: ("Find (Sources/Subs-Portal.php)") [Select]

// Are you using and old version of SMF 2? With this mode enabled we can maintain some compatibility with SMF 2 RC1.2 and below.
if (in_array($clean_forum_version, array('SMF 2.0 Beta 3 Public', 'SMF 2.0 Beta 3.1 Public', 'SMF 2.0 RC1', 'SMF 2.0 RC1-1', 'SMF 2.0 RC1 1', 'SMF 2.0 RC1.1', 'SMF 2.0 RC1.2')))
$context['SPortal']['core_compat'] = 'old';
// Are you using a core based theme? With this mod enabled we can maintain compatibility with Core based themes for SMF 2 RC2 and above.
elseif (isset($settings['theme_version']) && (version_compare($settings['theme_version'], '2.0 RC2', '<') || strpos($settings['theme_version'], '2.0 Beta') !== false) || $settings['name'] == 'Core Theme')
$context['SPortal']['core_compat'] = 'core';
else
$context['SPortal']['core_compat'] = false;

Code: ("Replace") [Select]

$context['SPortal']['core_compat'] = 'core';
If you use any other themes on your forum, then it would be a better idea to make a copy of the '/Themes/default/Portal.template.php' file in your '/Themes/{themename}/' folder, then have a go at changing the relevant code from that file.

[johncccccc]

I have used the Core theme from RC3 not the curve one, there are many differences in the templates, I know because Ive never seen a theme with so many templates.

That's probably why, I suspect that borders are removed from blocks since boarders on curve them would not look good.

FYI, I based my theme on Core (added drop down menu), not curve.


I have added some border values to the div sp block in portal.css, but it borders hidden stuff too.

I had time to make the above edit, works perfectly

Code: [Select]

   // Are you using a core based theme? With this mod enabled we can maintain compatibility with Core based themes for SMF 2 RC2 and above.
   elseif (isset($settings['theme_version']) && (version_compare($settings['theme_version'], '2.0 RC2', '<') || strpos($settings['theme_version'], '2.0 Beta') !== false) || $settings['name'] == 'Core Theme'

Maybe RC3 needed to be added in there somewhere too, Since people use core on SMF 2.0 RC3 too, or base there themes off of it anyway.

[johncccccc]

Worked Perfect, however now MY ajax chat window has a parcing error, I think its related to this


Use of undefined constant core - assumed 'core' in /home/******/****/****/Sources/Subs-Portal.php

[Nathaniel]

Make sure that you used:

Code: [Select]

$context['SPortal']['core_compat'] = 'core';
Not:

Code: [Select]

$context['SPortal']['core_compat'] = core;

[johncccccc]

Damn typo, that was it, fixed now

Thanks