Topic: SP messed up restricted guest access

[JBlaze]

SMF 2.0 RC1.2
SP 2.3.1

When guest access is disabled and SP is enabled in Front Page mode, instead of displaying a login screen to guests, it shows only the who's online and board stats areas and nothing else.

I checked to make sure that this wasn't a conflict between Users Online Today as well.

Mods installed:
1.    Referrals Mod      2.2.6
2.    MoodBobels    2.3.1
3.    SimplePortal    2.3.1
4.    Users Online Today    1.5.4
5.    Moderator and Administrator Comment Tags    1.3
6.    Spoiler Tag    0.6b
7.    AjaxChat Integration    3.2
8.    SMF 1.0.18 / 1.1.10 / 2.0 RC1-2 Update    1.1
9.    Aeva ~ Auto-Embed Video & Audio    7.0
10.    E-Arcade    Beta4-SMF2rc1
11.    Karma Buttons    1.1

[Norv]

It looks like the problem is here: (index.php)

Code: [Select]

// If guest access is off, a guest can only do one of the very few following actions.
elseif (empty($modSettings['allow_guestAccess'])
&& !(!empty($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach' && !empty($_REQUEST['type']) && $_REQUEST['type'] == 'avatar')
&& !(empty($_REQUEST['action'])  && empty($board) && empty($topic) && $modSettings['sp_portal_mode'] == 1)
&& $user_info['is_guest']
&& (!isset($_REQUEST['action']) || !in_array($_REQUEST['action'], array('coppa', 'login', 'login2', 'register', 'register2', 'reminder', 'activate', 'help', 'smstats', 'mailq', 'verificationcode', 'openidreturn',))))
{
require_once($sourcedir . '/Subs-Auth.php');
return 'KickGuest';
}
elseif (empty($_REQUEST['action']))
{
// Go catch it boy! Catch it!
$sp_action = sportal_catch_action();
if ($sp_action)
return $sp_action;


The first should happen, the 'KickGuest' action, but it doesn't :

Code: [Select]

!(empty($_REQUEST['action'])  && empty($board) && empty($topic) && $modSettings['sp_portal_mode'] == 1)
is false.

[Eliana Tamerin]

Reported: http://simpleportal.net/index.php?issue=305.0

[Nathaniel]

There is an edit to that area of the index.php file, that should have been removed in 2.3.1 (when the handling of the guest disable access setting was changed).

Remove this code:

Code: [Select]

&& !(!empty($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach' && !empty($_REQUEST['type']) && $_REQUEST['type'] == 'avatar') && !(empty($_REQUEST['action']) && empty($board) && empty($topic) && $modSettings['sp_portal_mode'] == 1)
Thanks for the bug report.

[JBlaze]

Thanks guys (and girl)

[tfs]

Remove this code:

I've removed the code, and it fixed the problem.  Will this cause trouble when the next SP ships and I try to uninstall?

[Nathaniel]

Remove this code:

I've removed the code, and it fixed the problem.  Will this cause trouble when the next SP ships and I try to uninstall?

When you try to uninstall your version of SimplePortal, it will give you a related error for the index.php file, which you can ignore. (Make sure you only ignore the error for that edit though)