[peteewheat]

Using SMF2.0 RC1.2
SP2.3.1
Internal site

I want to allow users to add articles, pending my approval before they are published. I can set this up ok with just checking the permissions box for adding an article. However, this box allows anyone with this permission checked to delete any article, without requiring approval.

It seems to me this should be seperated (permissions check for add article, remove article, requiring approval, etc. I don't ever want any of my members deleting articles.   Am I doing something wrong?

[Nathaniel]

Currently, the 'Remove Articles' button/task requires the 'Can Add Article' permission, a 'Can Remove Article' permission would be useful, although it makes sense for users with the 'Administrate portal' or the 'Manage portal articles' permissions to be able to remove articles.

Reported this issue to the Project tracker.
Bug report for bad permissions checking:
http://simpleportal.net/index.php?issue=309.0
Feature request for 'Can Remove Article' permission:
http://simpleportal.net/index.php?issue=310.0
Also found an issue with a deprecated permission:
http://simpleportal.net/index.php?issue=311.0

For now, the edits below, will allow users to remove articles, only if they have either the 'Administrate portal' or the 'Manage portal articles' permissions. (it fixes the bug)

Code ("Find (sources/PortalArticles.php)") Select Expand

if (!allowedTo('sp_add_article') && !allowedTo('sp_moderate'))
fatal_lang_error('error_sp_cannot_remove_article');

Code ("Replace") Select Expand

if (!allowedTo('sp_admin') && !allowedTo('sp_manage_articles'))
fatal_lang_error('error_sp_cannot_remove_article');

Code ("Find (sources/Subs-Portal.php)") Select Expand

if (!empty($context['current_topic']))
$context['can_make_article'] = allowedTo(array('sp_admin', 'sp_manage_articles', 'sp_add_article'));


Code ("Replace") Select Expand

if (!empty($context['current_topic']))
{
$context['can_make_article'] = allowedTo(array('sp_admin', 'sp_manage_articles', 'sp_add_article'));
$context['can_remove_article'] = allowedTo(array('sp_admin', 'sp_manage_articles'));
}

Code ("Find (Themes/default/Display.template.php)") Select Expand

if ($context['can_make_article'])

Code ("Replace") Select Expand

if ((!$context['topic_is_article'] && $context['can_add_article']) || ($context['topic_is_article'] && $context['can_remove_article']))

[peteewheat]

Thanks for the quick response! Works great with one minor hiccup. I couldn't add articles any more.

I changed:

Code (Themes/default/Display.template.php) Select Expand

if ((!$context['topic_is_article'] && $context['can_add_article']) || ($context['topic_is_article'] && $context['can_remove_article']))

to:

Code (Themes/default/Display.template.php) Select Expand

if  ((!$context['topic_is_article'] && $context['can_make_article']) || ($context['topic_is_article'] && $context['can_remove_article']))

Hopefully I did that right. So far, it seems to be working.

[Nathaniel]

Yep, that looks good, made a type in my post.