Topic: shoutbox lets crash webserver/php

[azunai]

hey, ok the last 3 days were like hell -.-
problem occured: forums index page was just blank
apache went to 100%cpu + 900mb ram usage
load ~ 30

after google was my best friend for 1 day i resigned on apache and installed nginx
and since today i tried everything to get my forum back online
my forums database was spammed with errors 2.000.000 entrys  but all sensless (login failed and so on)
produced in 2 or 3 hours

and now, i found the problems source, i installed a fresh smf v1.1.11 and installed the simple portal 2.3.1 package, guess what happend -.- blank index, 100%cpu everything f***ed up

i dont get why, cause im using simple portal for month now

do you have any ideas? or hints to get it back to work?

greetings

www.gamerevision.com

edit: haha got deeper, seems to be the shoutbox
edit2: hm a new shoutbox works, strange
edit3!!!!!!!!
found the bug!!!!!!!

just paste "bla-email@web.de" into a sp 2.3.1 sb and everything crashes

edit4: paste any email adress into the sb and it crashs
checkin why atm

Edit-> Removed obscene language

[azunai]

fixed!

simpyl added

Code: [Select]

$shout = str_replace("@","(at)",$shout);in line 1354 in Subs-Portal.php Source dir

[Nathaniel]

There are currently unresolved issues with the parse_bcc function being used within the shoutbox, stopping email addresses from being parsed removes many of the performance issues.

Here is the fix being used at SimplePortal.net (from Sinan):
Sources/Subs.php

Code: (Find) [Select]

$disabled, $parse_tag_cache;

Code: (Replace) [Select]

$disabled, $default_disabled, $parse_tag_cache;

Code: (Find) [Select]

if ($parse_tags !== array() && is_array($parse_tags))
{
$temp_bbc = $bbc_codes;
$tags_cache_id = implode(',', $parse_tags);

if (isset($parse_tag_cache[$tags_cache_id]))
$bbc_codes = $parse_tag_cache[$tags_cache_id];
else
{
foreach ($bbc_codes as $key_bbc => $bbc)
foreach ($bbc as $key_code => $code)
if (!in_array($code['tag'], $parse_tags))
unset($bbc_codes[$key_bbc][$key_code]);

$parse_tag_cache = array($tags_cache_id => $bbc_codes);
}
}

Code: (Replace) [Select]

if ($parse_tags !== array() && is_array($parse_tags))
{
$temp_bbc = $bbc_codes;
$tags_cache_id = implode(',', $parse_tags);

if (!isset($default_disabled))
$default_disabled = isset($disabled) ? $disabled : array();

if (isset($parse_tag_cache[$tags_cache_id]))
list ($bbc_codes, $disabled) = $parse_tag_cache[$tags_cache_id];
else
{
foreach ($bbc_codes as $key_bbc => $bbc)
foreach ($bbc as $key_code => $code)
if (!in_array($code['tag'], $parse_tags))
{
$disabled[$code['tag']] = true;
unset($bbc_codes[$key_bbc][$key_code]);
}

$parse_tag_cache = array($tags_cache_id => array($bbc_codes, $disabled));
}
}
elseif (isset($default_disabled))
$disabled = $default_disabled;

[steve51184]

There are currently unresolved issues with the parse_bcc function being used within the shoutbox, stopping email addresses from being parsed removes many of the performance issues.

Here is the fix being used at SimplePortal.net (from Sinan):
Sources/Subs.php

Code: (Find) [Select]

$disabled, $parse_tag_cache;

Code: (Replace) [Select]

$disabled, $default_disabled, $parse_tag_cache;

Code: (Find) [Select]

if ($parse_tags !== array() && is_array($parse_tags))
{
$temp_bbc = $bbc_codes;
$tags_cache_id = implode(',', $parse_tags);

if (isset($parse_tag_cache[$tags_cache_id]))
$bbc_codes = $parse_tag_cache[$tags_cache_id];
else
{
foreach ($bbc_codes as $key_bbc => $bbc)
foreach ($bbc as $key_code => $code)
if (!in_array($code['tag'], $parse_tags))
unset($bbc_codes[$key_bbc][$key_code]);

$parse_tag_cache = array($tags_cache_id => $bbc_codes);
}
}

Code: (Replace) [Select]

if ($parse_tags !== array() && is_array($parse_tags))
{
$temp_bbc = $bbc_codes;
$tags_cache_id = implode(',', $parse_tags);

if (!isset($default_disabled))
$default_disabled = $disabled;

if (isset($parse_tag_cache[$tags_cache_id]))
list ($bbc_codes, $disabled) = $parse_tag_cache[$tags_cache_id];
else
{
foreach ($bbc_codes as $key_bbc => $bbc)
foreach ($bbc as $key_code => $code)
if (!in_array($code['tag'], $parse_tags))
{
$disabled[$code['tag']] = true;
unset($bbc_codes[$key_bbc][$key_code]);
}

$parse_tag_cache = array($tags_cache_id => array($bbc_codes, $disabled));
}
}
elseif (isset($default_disabled))
$disabled = $default_disabled;

so what does this do? does it fix the problem? and is it now safe to use the shoutbox with this edit?

[Nathaniel]

Please do not double post.

That edit stops the error from occuring, by stopping SMF from parsing email addresses within the shoutbox. Normally it would turn them into an email link.

[steve51184]

Please do not double post.

That edit stops the error from occuring, by stopping SMF from parsing email addresses within the shoutbox. Normally it would turn them into an email link.

i didn't double post... anyways this is a 100% fix 'will never happen again' thing?

[Nathaniel]

Please do not double post.

That edit stops the error from occuring, by stopping SMF from parsing email addresses within the shoutbox. Normally it would turn them into an email link.

i didn't double post... anyways this is a 100% fix 'will never happen again' thing?

You posted the same question in two separate topics. Anyway, yes, this edit should fix the problem. There is never a !00% chance that it will never happen again, but this same solution has worked for other people, so there is no reason why it should not work for you.

[steve51184]

thank you

also why is this not included with SP?

[Nathaniel]

Because there hasn't been a SP bugfix release since this bug was first discovered.

[steve51184]

Because there hasn't been a SP bugfix release since this bug was first discovered.

seems like it needs to be fixed to me :\

[steve51184]

tht code/fix has some problems: all images are showing all weird (out of line) and quotes aren't working... how do i fix this?

[steve51184]

any ideas about my last post?

[steve51184]

fixed!

simpyl added

Code: [Select]

$shout = str_replace("@","(at)",$shout);in line 1354 in Subs-Portal.php Source dir

where exactly do i add this? (ie. before/after what?)

[steve51184]

tht code/fix has some problems: all images are showing all weird (out of line) and quotes aren't working... how do i fix this?

hate to quad post but i did wait almost a week..

anyway that fix messes up all my images and stops quotes from showing so i had to take it off so can you fix that please as if anyone posts an email address my server will crash lol

[steve51184]

6th bump please reply

[Nathaniel]

The fix in the post below should work:
http://simpleportal.net/index.php?topic=4126.msg26219#msg26219

Check that you have applied it correctly.

[steve51184]

The fix in the post below should work:
http://simpleportal.net/index.php?topic=4126.msg26219#msg26219

Check that you have applied it correctly.

i did but it didn't work

[steve51184]

replied here:

http://simpleportal.net/index.php?topic=4168.msg28682#msg28682

[ibrrorg]

Didn't know whether to post here or start afresh, so opted to post here as the issue was identical.

So, this is the post that started it all for me.  Portal is stable again, but I cannot implement the shoutbox even following the fix SiNaN suggests here doesn't seem to fix it.

I want to get a little deeper, though.  SMF 2.0 RC2, SP 2.3.1, Curve/Default theme, my site is here.  So, simply loading the shoutbox crashes/locks down my system.  Goes back to the original reasons why I had to pull it.  Is this a SMF or SP issue and is there hope for a fix any time soon?

[[SiNaN]]

ibrrorg, that fix would have fixed the issue. Can you provide me an admin account and FTP access via pm? I could check it for you.