Author Topic: sp resizing for sp_articles (Read 2908 times)

AngelinaBelle · « **on:** March 11, 2010, 01:55:32 PM »

I noticed that function sp_image_resize() handles class="sp_article" in a way I hadn't expected. (though maybe I should have).
It basically uses it as a search string. So, if the element has a SRC property and class=sp_article, it will explicitly add a height and width to the element, on the fly, scaling the image to a fixed 300 width.

I am inexperienced here, so I would like to ask a small number of questions from those of you who have actually tried out the different options here.
1) a) Why is this manipulating all the <imga tags directly a better choice than setting max-width for img.sp_article?
c) Why not dynamically-manipulated stylesheets, à la http://www.hunlock.com/blogs/Totally_Pwn_CSS_with_Javascript)
(no, I have never tried dynamic CSS. yet. It's on my list.)

2) Would extending/supplementing sp_image_resize be a good way to manipulate other things users might have embedded, like <object and <embed (from the [pdf] tag)? Implementation would be simple -- just iterate over "img", "object", "embed" , using the appropriate javascript DOM objects and properties in each case...

AngelinaBelle · « **Reply #1 on:** March 12, 2010, 09:51:33 PM »

OK, so I'm replying to my own question AGAIN, after I've ground my teeth on the code for a bit.

I'm happy with my first tests. It seems to work well even if some *****ss has used [html]<img height=..... in the posting. It seems like clean code to me.
Is this a good idea?
How do you think it compares to the current way sp_image_resize is handled in php and JavaScript?

Maybe it would be better to just put this into <head> the normal way, and use $modSettings['sp_resize_images'] to control putting the class on the article bodies?

Are there important browser issues I am unaware of because I'm only testing with IE8/IE7?

Code: (portal_resize.css) [Select]

.sp_articles_body img
{
 max-width: 100px;
 width: auto;
 height: auto;
}

Code: (function sp_articles) [Select]

...
foreach ($articles as $article)
{
...
   echo '<br/ ><div class=sp_articles_body>', $article['msg']['body'], '</div>';
...
}
...
  if ($modSettings['sp_resize_images'])
   {
    echo '
  <script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
   var cssNode = document.createElement("link");
   cssNode.type = "text/css";
   cssNode.rel = "stylesheet";
   cssNode.href = "', $settings['default_theme_url'], '/portal_resize.css";
   cssNode.media = "screen";
   cssNode.title = "dynamicLoadedSheet";
   document.getElementsByTagName("head")[0].appendChild(cssNode); 
  // ]]></script>';
   }

AngelinaBelle · « **Reply #2 on:** March 16, 2010, 04:28:56 PM »

OK. I think I've got the answer to my question.
Bad browsers.

Simple Portal Archived Forum

User Info

Who's Online

Shoutbox

Team Blog

Recent Posts

Author Topic: sp resizing for sp_articles (Read 2908 times)

AngelinaBelle

sp resizing for sp_articles

AngelinaBelle

Re: sp resizing for sp_articles

AngelinaBelle

Re: sp resizing for sp_articles