Topic: After upgrade to 2.3.2, block background color bleeds over

[tfs]

SMF 2.0 RC3, Curve theme.

See attached images.  I use a "custom body style" on the portal blocks.  With SP 2.3.1 the background color of the block body always stayed within the confines of the defined border.  Now with 2.3.2 the background color pushes out of the border.

In the "Style Options/Custom Body Style" I have the following...

Code: [Select]

border-style:double;border-width:3px ;border-top-width:6px ;border-right-width:4px ;border-left-width:4px ;border-color:#5A6C85; -moz-border-radius: 8px; -webkit-border-radius: 10px;padding:15px; margin: 15px;margin-bottom: 5px;

But as you can see in the before and after picture, after upgrading to 2.3.2 the background color escapes the border area.

Is it an issue with my custom CSS?

[[SiNaN]]

Remove this from "Custom Body Style":

Code: [Select]

margin: 15px;margin-bottom: 5px;
Check the "No Body" option.

Add this to the "Custom Body Class":

Code: [Select]

windowbg
How does that look?

[tfs]

The background color stays within the border, but now the side margins are gone, which causes the box width (border) to come out nearly against the side blocks.  Will attach another file...

If I put the margins back into the CSS but leave the "no body" option checked, and leave "windowbg" in the custom body class, then the side content color still bleeds out the sides, though no longer the top and bottom.

[tfs]

Anything new on this one?  I'd really like to keep some background color while using margins.

[[SiNaN]]

I can't say this is a bug, but will provide a solution for you:

Themes/default/Portal.template.php

Code: (Find) [Select]

<div class="', $block['type'] != 'sp_menu' ? 'sp_block' : 'sp_content_padding', '"', !empty($block['style']['body']['style']) ? ' style="' . $block['style']['body']['style'] . '"' : '', '>';

Code: (Replace) [Select]

<div class="', $block['type'] != 'sp_menu' ? 'sp_block' : 'sp_content_padding', '">';

Code: (Find) [Select]

<div', empty($block['style']['body']['class']) ? '' : ' class="' . $block['style']['body']['class'] . '">';

Code: (Replace) [Select]

<div', empty($block['style']['body']['class']) ? '' : ' class="' . $block['style']['body']['class'] . '"', !empty($block['style']['body']['style']) ? ' style="' . $block['style']['body']['style'] . '"' : '', '>';

[tfs]

Thanks SiNaN, the body background now stays within the confines of the border.  I appreciate it!

[tfs]

I'm trying to apply this same fix to SMF RC4 and SP 2.3.3, but the 2nd "find" isn't found in the file Portal.template.php.  Could you please help me to apply this fix to RC4/2.3.3?

[Nathaniel]

Code: (Find) [Select]

<div', empty($block['style']['body']['class']) ? '' : ' class="' . $block['style']['body']['class'] . '"', '>';

Code: (Replace) [Select]

<div', empty($block['style']['body']['class']) ? '' : ' class="' . $block['style']['body']['class'] . '"', !empty($block['style']['body']['style']) ? ' style="' . $block['style']['body']['style'] . '"' : '', '>';