Topic: [SMF 2.0 RC5] Undefined variable: avatar_height ??

[Kobar]

Hello all

Error log gives me this problem:

8: Undefined variable: avatar_height
File: ~/forum/Sources/PortalBlocks.php(3351) : eval()'d code
Line: 37

Please help me

[AngelinaBelle]

This error message tells you that the error occurs in eval'd code which is called FROM PortalBlocks.php on line 3351.
BUT the error is in line 37 of the eval'd code.
So the error is in one of your custom php blocks

[grafitus]

I think you waoring with PHP block. Give to me your PHP codes to I check.

[Kobar]

Profile Statusses:

Code: [Select]

global $smcFunc, $modSettings, $scripturl, $txt, $color_profile;

$limit = 5;
$txt['comments'] = 'Reacties';

$request = $smcFunc['db_query']('', '
   SELECT ls.id_status, ls.id_member, mem.real_name, mem.avatar,
      a.id_attach, a.attachment_type, a.filename,
      ls.post_date AS time, ls.post, ls.reply_count AS num_replies
   FROM {db_prefix}log_statuses AS ls
      INNER JOIN {db_prefix}members AS mem  ON (ls.id_member = mem.id_member)
      LEFT JOIN {db_prefix}attachments AS a ON (a.id_member = mem.id_member)
   ORDER BY {raw:sort}
   LIMIT {int:limit}',
   array(
      'sort' => 'id_status DESC',
      'limit' => $limit,
   )
);
$statuses = array();
$colorids = array();
while ($row = $smcFunc['db_fetch_assoc']($request))
{
   if (!empty($row['id_member']))
      $colorids[$row['id_member']] = $row['id_member'];

   $statuses[] = array(
      'id' => $row['id_status'],
      'id_member' => $row['id_member'],
      'member' => array(
         'id' => $row['id_member'],
         'name' => $row['real_name'],
         'href' => $scripturl . '?action=profile;u=' . $row['id_member'],
         'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>',
         'avatar' => array(
            'name' => $row['avatar'],
            'image' => $row['avatar'] == '' ? ($row['id_attach'] > 0 ? '<img src="' . (empty($row['attachment_type']) ? $scripturl . '?action=dlattach;attach=' . $row['id_attach'] . ';type=avatar' : $modSettings['custom_avatar_url'] . '/' . $row['filename']) . '" alt="" class="avatar" border="0" />' : '') : (stristr($row['avatar'], 'http://') ? '<img src="' . $row['avatar'] . '"' . $avatar_width . $avatar_height . ' alt="" class="avatar" border="0" />' : '<img src="' . $modSettings['avatar_url'] . '/' . htmlspecialchars($row['avatar']) . '" alt="" class="avatar" border="0" />'),
            'href' => $row['avatar'] == '' ? ($row['id_attach'] > 0 ? (empty($row['attachment_type']) ? $scripturl . '?action=dlattach;attach=' . $row['id_attach'] . ';type=avatar' : $modSettings['custom_avatar_url'] . '/' . $row['filename']) : '') : (stristr($row['avatar'], 'http://') ? $row['avatar'] : $modSettings['avatar_url'] . '/' . $row['avatar']),
            'url' => $row['avatar'] == '' ? '' : (stristr($row['avatar'], 'http://') ? $row['avatar'] : $modSettings['avatar_url'] . '/' . $row['avatar'])
         ),
      ),
      'time' => timeformat($row['time']),
      'post' => parse_bbc($row['post']),
      'num_replies' => comma_format($row['num_replies']),
   );
}
$smcFunc['db_free_result']($request);

if (empty($statuses))
   return;
else
   $statuses[count($statuses) - 1]['is_last'] = true;

if (!empty($colorids) && sp_loadColors($colorids) !== false)
   foreach ($statuses as $k => $status)
      if (!empty($color_profile[$status['member']['id']]['link']))
         $statuses[$k]['member']['link'] = $color_profile[$status['member']['id']]['link'];
echo '
   <table class="sp_fullwidth">';
foreach ($statuses as $status)
   echo '
         <tr>
            <td class="sp_top_poster sp_center">', !empty($status['member']['avatar']['href']) ? '
               <img src="' . $status['member']['avatar']['href'] . '" alt="' . $status['member']['name'] . '" width="40" />' : '', '
            </td>
            <td>
               ', $status['post'], '<br />
               ', $txt['by'], ': ', $status['member']['link'], '<br />
               ', $txt['comments'], ': ', $status['num_replies'], '<br />
               ', $status['time'], (empty($status['is_last']) ? '<hr />' : ''), '
            </td>
         </tr>';
echo '
   </table>';
This is the only own php I have added

[AngelinaBelle]

So, before you use the variables $avatar_width and $avatar_height, you should define them.

Code: [Select]

$avatar_width=16px;
$avatar_height=16px;
Something like that.

[Kobar]

I don't know how to do that. I have let this php block made by one of you

[grafitus]

Oh, it's mine!

Use this:

Code: [Select]

global $smcFunc, $modSettings, $scripturl, $txt, $color_profile;

$limit = 5;
$txt['comments'] = 'Reacties';

$request = $smcFunc['db_query']('', '
SELECT ls.id_status, ls.id_member, mem.real_name, mem.avatar,
a.id_attach, a.attachment_type, a.filename,
ls.post_date AS time, ls.post, ls.reply_count AS num_replies
FROM {db_prefix}log_statuses AS ls
INNER JOIN {db_prefix}members AS mem  ON (ls.id_member = mem.id_member)
INNER JOIN {db_prefix}attachments AS a ON (a.id_member = mem.id_member)
ORDER BY {raw:sort}
LIMIT {int:limit}',
array(
'sort' => 'id_status DESC',
'limit' => $limit,
)
);
$statuses = array();
$colorids = array();
while ($row = $smcFunc['db_fetch_assoc']($request))
{
if (!empty($row['id_member']))
$colorids[$row['id_member']] = $row['id_member'];

$statuses[] = array(
'id' => $row['id_status'],
'id_member' => $row['id_member'],
'member' => array(
'id' => $row['id_member'],
'name' => $row['real_name'],
'href' => $scripturl . '?action=profile;u=' . $row['id_member'],
'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>',
'avatar' => array(
'name' => $row['avatar'],
'image' => $row['avatar'] == '' ? ($row['id_attach'] > 0 ? '<img src="' . (empty($row['attachment_type']) ? $scripturl . '?action=dlattach;attach=' . $row['id_attach'] . ';type=avatar' : $modSettings['custom_avatar_url'] . '/' . $row['filename']) . '" alt="" class="avatar" border="0" />' : '') : (stristr($row['avatar'], 'http://') ? '<img src="' . $row['avatar'] . '"' . $avatar_width . $avatar_height . ' alt="" class="avatar" border="0" />' : '<img src="' . $modSettings['avatar_url'] . '/' . htmlspecialchars($row['avatar']) . '" alt="" class="avatar" border="0" />'),
'href' => $row['avatar'] == '' ? ($row['id_attach'] > 0 ? (empty($row['attachment_type']) ? $scripturl . '?action=dlattach;attach=' . $row['id_attach'] . ';type=avatar' : $modSettings['custom_avatar_url'] . '/' . $row['filename']) : '') : (stristr($row['avatar'], 'http://') ? $row['avatar'] : $modSettings['avatar_url'] . '/' . $row['avatar']),
'url' => $row['avatar'] == '' ? '' : (stristr($row['avatar'], 'http://') ? $row['avatar'] : $modSettings['avatar_url'] . '/' . $row['avatar'])
),
),
'time' => timeformat($row['time']),
'post' => parse_bbc($row['post']),
'num_replies' => comma_format($row['num_replies']),
);
}
$smcFunc['db_free_result']($request);

if (empty($statuses))
return;
else
$statuses[count($statuses) - 1]['is_last'] = true;

if (!empty($colorids) && sp_loadColors($colorids) !== false)
foreach ($statuses as $k => $status)
if (!empty($color_profile[$status['member']['id']]['link']))
$statuses[$k]['member']['link'] = $color_profile[$status['member']['id']]['link'];
echo '
<table class="sp_fullwidth">';
foreach ($statuses as $status)
echo '
<tr>
<td class="sp_top_poster sp_center">', !empty($status['member']['avatar']['href']) ? '
<img src="' . $status['member']['avatar']['href'] . '" alt="' . $status['member']['name'] . '" width="40" />' : '', '
</td>
<td>
', $status['post'], '<br />
', $txt['by'], ': ', $status['member']['link'], '<br />
', $txt['comments'], ': ', $status['num_replies'], '<br />
', $status['time'], (empty($status['is_last']) ? '<hr />' : ''), '
</td>
</tr>';
echo '
</table>';

[Kobar]

Should I replace it?

[AngelinaBelle]

You could try making the change and see if you like it.


If you are going to work with custom php blocks ever again, I think you will enjoy reading a nice tutorial. Try the one at w3schools.com. Also, try reading the language reference at php.net.  You will learn a lot, and it will make it easier to deal with small customizations.


Remember -- writing code ALWAYS means making mistakes.

[Kobar]

Ok, no problems with this new code so far. Thanks!

[AngelinaBelle]

Glad it worked!