Topic: Wrong menu button is highlighted on board index with ADK Blog installed

[phantomm]

Hi, is it normal that Home button is highlighted when I'm on board index page? When I go to any board/topic Forum button is marked.
SP is in standalone mode.

SP 2.3.5
SMF 2.0.7

[AngelinaBelle]

That seems a little unusual.  Which theme are you using?  Curve, for example, uses the information the buttons array to designate which button is class="active".  Are you using any other mods which have any affect on the buttons array, or which have changed how the theme shows the nav menu?


And/or in addition to that, anything which has changed the CSS that is applied to the nav buttons?

[phantomm]

I have this bug in all installed themes (Inferno by DS, Curve and others). Some installed mods are adding new buttons in menu (Aeva, ADK Blog).
CSS for menu is not changed.

[AngelinaBelle]

I have not seen your site, so I am talking through my hat.

When you start troubleshooting a problem, the first step is to narrow things down.
The problem occurs in the default theme.  CSS is not changed, so I assume the difficulty is in the php code that creates the buttons.

To narrow this down further, I would try disabling all suspect mods and seeing if the problem goes away.  If it goes away, then we can figure out which mod is related to the problem.  (I assume that, if you have ONLY simpleportal installed, you will not see the problem, but you can test this yourself).

Then, it should be easier to look at the code and understand where SimplePortal and one other mod might be "having a fight" about which button should be marked "active".

[phantomm]

I should do this before i posted this topic but I'm too lazy... ADK Blog is causing this 'bug'.
I'll post here solution when I rewrite menu code from this mod, maybe someone will need it.

[AngelinaBelle]

Good job narrowing this down.  Always check the quick and simple things first because you can often get to the solution faster that way.

If you are clever about it, both mod authors might potentially be interested in a simple way to make their mod more compatible with other mods.

[phantomm]

Only solution I found for now is this small edit in ./Sources/Subs.php:

Code: (Find) [Select]

//Blog Button - Adk Portal Customizers
$current_action = isset($_REQUEST['blog']) ? 'blogs' : 'home';


Code: (Replace with) [Select]

//Blog Button - Adk Portal Customizers
$current_action = isset($_REQUEST['blog']) ? 'blogs' : ($modSettings['sp_portal_mode'] == 3 && empty($context['standalone']) && empty($context['disable_sp']) ? 'forum' : 'home');

May not be ideal, but works for me Topic marked as solved and also I changed topic name for future 'search' requests

[AngelinaBelle]

Seems about right.
I guess there is no more general way to do this -- all these different mods have no idea what other mods might also have laid claim to different parts of the site.