Topic: Uninstall error with subs.php

[Farjo]

I seem to be having the opposite problem as this person. I am uninstalling SP 2.3.3 in order to upgrade SMF from RC4 to RC5. During the test run I get an error looking for this code in subs.php

Code: [Select]

$add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:';

// Set the default redirect location as the forum or the portal.
if ((empty($setLocation) || $scripturl == $setLocation) && ($modSettings['sp_portal_mode'] == 1 || $modSettings['sp_portal_mode'] == 3))
{
// Redirect the user to the forum.
if (!empty($modSettings['sp_disableForumRedirect']))
$setLocation = 'action=forum';
// Redirect the user to the SSI.php standalone portal.
elseif ($modSettings['sp_portal_mode'] == 3)
{
$setLocation = $context['portal_url'];
$add = false;
}
}
Looking at the file I have the add preg_match line but the "Set the default redirect location" block does not exist anywhere in the file. Shall I just add it or is there something more worrying going on?

Thank you.

[AngelinaBelle]

Since you are uninstalling all mods before doing the RC4 -> RC5, it might be just as easy to
* uninstall all, ignoring all complaints and errors
* get fresh copies of these php files from the RC5 upgrade.


With fresh RC5 files, you won't have to worry about strange goings-on in your files.


Then, you can install the RC5-compatible versions of all your mods.

[Farjo]

Will do, thanks

[Farjo]

Thanks that worked.

For the record I think it relates to this error. What must have happened is that I downloaded the original 2.3.3 file and for whatever reason didn't correct the code, so the uninstall process couldn't find the text that hadn't been added

[AngelinaBelle]

Glad that worked