Topic: RSS errors

[aharpham]

SMF Version: 1.1.10
Simple Protal: 2.2.2
Board: http://bighuskerfan.com/smf/portal.php

We are testing Simple portal in stand alone until we get it setup the way we want it.

We are having trouble with the rss feeds.  When I set them up and preview them they look good, but when we view them on the portal we get:

Notice: iconv() [function.iconv]: Detected an illegal character in input string in /home/bighuskerfan/www/smf/Sources/SPortal1-1.php on line 2246

The feed is: http://www.huskers.com/rss.dbml?db_oem_id=100&media=news

or

The feed is http://www.huskers.com/rss.dbml?db_oem_id=100&sport_id=22&media=photos


On the ones with photos, is it possible to show the photos?

Any help would be appreciated.

Allen

[ccbtimewiz]

Hi aharpham, is this still an issue?

[[SiNaN]]

It should be poor inconv() function, just like xml_parser() function. Try this:

./Sources/PortalBlocks.php

Code: (Find) [Select]

$xml_parser = xml_parser_create();

Code: (Replace) [Select]

$xml_array = new xmlArray($xml_data);

if (!$xml_array->exists('rss[0]'))
echo 'error';
$xml_array = $xml_array->path('rss[0]');
$xml_array = $xml_array->path('channel[0]');

$items = array();
$counter = 0;
foreach ($xml_array->set('item') as $item)
{
$items[$counter] = array(
'title' => strip_tags($item->fetch('title')),
'content' => strip_tags($item->fetch('description')),
'href' => strip_tags($item->fetch('link')),
'image' => strip_tags($item->fetch('enclosure/@url')),
);
$items[$counter]['link'] = '<a href="' . $items[$counter]['href'] . '" target="_blank" class="new_win">' . $items[$counter]['title'] . '</a>';
$counter++;
}
/*
$xml_parser = xml_parser_create();

Code: (Find) [Select]

if (empty($items))
{
echo '
', $txt['error_sp_invalid_feed'];

Code: (Replace) [Select]

*/
if (empty($items))
{
echo '
', $txt['error_sp_invalid_feed'];

Code: (Find) [Select]

$item['content'], '</li>';

Code: (Replace) [Select]

!empty($item['image']) ? '<img src="' . $item['image'] . '" alt="" style="padding-right: 3px; float: left; width: 100px;" />' : '', $item['content'], '<br style="clear: both; line-height: 0;" /></li>';

[aharpham]

I applied the fix to another site I am working on.

The RSS feed now works, but 2 problems arise.

1. When the block is defined and the number of Items to show are set, the code now ignores the item limit.

2. The SMF error log fills up with 1024: Undefined XML element: enclosure and Undefined XML attribute: url

[AngelinaBelle]

1. Looks like you need to make the loop quit when $counter reaches $count
2. You can see that the offending attributes come with 'img', but the block never uses $items[]['img']. In a case like this -- why not just eliminate that line of code?
 
That would turn [SiNaN]'s replacement block of code into this COMPLETELY UNTESTED block of code.
Please let us know if it works on your forum.

Code: (Replace) [Select]

   $xml_array = new xmlArray($xml_data);

   if (!$xml_array->exists('rss[0]'))
      echo 'error';
   $xml_array = $xml_array->path('rss[0]');
   $xml_array = $xml_array->path('channel[0]');

   $items = array();
   $counter = 0;
   foreach ($xml_array->set('item') as $item)
   {
      $items[$counter] = array(
         'title' => strip_tags($item->fetch('title')),
         'content' => strip_tags($item->fetch('description')),
         'href' => strip_tags($item->fetch('link')),
      );
      $items[$counter]['link'] = '<a href="' . $items[$counter]['href'] . '" target="_blank" class="new_win">' . $items[$counter]['title'] . '</a>';
 
// When the $counter reaches $count, it is time to break out of the foreach loop
      if (++$counter == $count)
            break;
   }
/*
   $xml_parser = xml_parser_create();

[aharpham]

I had already done that, and it works.  Just no images.

I can live with that for now.

Thanks, Allen

[AngelinaBelle]

I'm glad you have now solved the two small problems with [SiNaN]'s workaround code block.
That quick workaround now solves one of your problems (the errors thrown), but not the other one (you want pictures in the block)
 
Are you OK with marking this topic solved?
 
It looks like you are using some custom php to get the RSS for blocks like "Huskers.com Football".

[teebag]

The feed is: http://www.huskers.com/rss.dbml?db_oem_id=100&media=news

or

The feed is http://www.huskers.com/rss.dbml?db_oem_id=100&sport_id=22&media=photos

Does the &media=news and &sport_id=22&media=photos part work? on my portal, it seems to ignore any parameters sent

[AngelinaBelle]

When I look at these two feeds with a newsreader, I see that one is headline news, while the other is photo albums.
 
Headline News works fine, but the newsreader does not show the images from the photo album, and most of the description elements are simply empty.
 
The XML validator does not indicate an error with the feed, but does make a couple of recommendations for http://www.huskers.com/rss.dbml?db_oem_id=100&sport_id=22&media=photos
 
 
But you are saying that the RSS block doesn't seem to be using the parameters at all.
Figuring this out would mean debugging fetch_web_data in Subs-Package.php.

Code: [Select]

preg_match('~^(http|ftp)(s)?://([^/:]+)(:(\d))?(.+)$~', $url, $match);and

Code: [Select]

elseif (isset($match[1]) && $match[1] == 'http')
 {
  if ($keep_alive && $match[3] == $keep_alive_dom)
   $fp = $keep_alive_fp;
  if (empty($fp))
  {
   // Open the socket on the port we want...
   $fp = @fsockopen(($match[2] ? 'ssl://' : '') . $match[3], empty($match[5]) ? ($match[2] ? 443 : 80) : $match[5], $err, $err, 5);
   if (!$fp)
    return false;
  }
It's the contents of the @fsockopen line that are important here.
One way to test this is to create a copy of this function, give it a new name, put it right before the sp_rssFeeds, and call it instead of fetch_web_data.  Then you can add all the brute-force debugging code you want without messing up the "real" version.
 
If fetch_web_data turns out not to be suitable for the RSS feeds, there will have to be a suitable replacement.