Topic: Undefined offset: 1 when viewing page

[Inti31]

Hi, won't start a new topic to this error which fills up just my error log.

Yesterday I did (again) a fresh install (testforum) of SMF 2.0 Gold, also I installed Simpleportal 2.3.3 and x other mods.
The error log shows for each page (xxx) that line:

Code: [Select]

....index.php?page=pg_xxx 8: Undefined offset: 1
Datei: /home/syscp/webs/<private>/smf/Sources/PortalPages.php
line: 91

line 91:

Code: [Select]

if (preg_match('~s:4:"page";s:\d+:"([^"]+)";~', $row['url'], $match) === false || $match[1] != $page_id)
Any updates to that? I searched for but I didn't find a solution.

cheers Inti31

[AngelinaBelle]

I hope you will not mind that I split this topic from the other one.  It was not at all related
I am very confused by this error.
I just downloaded SimplePortal 2.3.3, simply to check. I looked in the smf2 directory, and found the file PortalPages.php.  In this file, I see only 69 lines.  None of them contain "preg_match".
Have you customized PortalPages.php in any way?

[Inti31]

I just implemented the language file in the installer package else I installed "who is online" on pages
in the past (and i installed simplePortal a lot) I had no errors in the error log.
please see att'ed file:

cheers inti31

[ccbtimewiz]

$match at that point does not exist, let alone as an array. There might be some problem with the file itself or the way it is being executed, I can't be sure.

You could try doing this as a temporary fix until a developer looks at it or if I have time to look more closely.

Find:

Code: [Select]

if (preg_match('~s:4:"page";s:\d+:"([^"]+)";~', $row['url'], $match) === false || $match[1] != $page_id)
continue;
Replace with:

Code: [Select]

if (is_array($match) || !empty($match))
if (preg_match('~s:4:"page";s:\d+:"([^"]+)";~', $row['url'], $match) === false || $match[1] != $page_id)
continue;

[Inti31]

okay, I tried this - as I said - all pages run fine - it  is just the error message which fills the log

now I have in the same line (91) this entry for each page.

Code: [Select]

8: Undefined variable: match
Datei: /home/syscp/webs/<private>/smf/Sources/PortalPages.php

cheers inti31

[ccbtimewiz]

That's weird, it should not do that anymore, I guess $match is an array and is set, just no keys?

Could try this for now then,

Find:

Code: [Select]

if (is_array($match) || !empty($match))
if (preg_match('~s:4:"page";s:\d+:"([^"]+)";~', $row['url'], $match) === false || $match[1] != $page_id)
continue;
Replace with:

Code: [Select]

$match = array(1 => '');
if (preg_match('~s:4:"page";s:\d+:"([^"]+)";~', $row['url'], $match) === false || $match[1] != $page_id)
continue;

[[SiNaN]]

preg_match() will return false only if an error occurs in preg_match(). If there are no errors, but still no matches, it will return 0. Changing the initial line with the following should fix it:

Code: [Select]

if (!preg_match('~s:4:"page";s:\d+:"([^"]+)";~', $row['url'], $match) || $match[1] != $page_id)
I should also note that the line is from a custom edit. That line doesn't exist in SP by default.

[grafitus]

I should also note that the line is from a custom edit. That line doesn't exist in SP by default.

That the line is from my customization.

And thanks your solution! Updated pack on the mod topic.

[Inti31]

okay - very nice that I could help out -  - to fix a problem has nothing to do with SimplePortal itself - sorry for that -
it's all grafitus fault - I am just kidding.

Thx to all helped out in that matter.

The error message is gone, by the way...  - well done...

cheers Inti31

Maybe an admin could update the "Profile - Account Settings" page -
 there is need to add  2.0 Gold as an option by "SMF Version".