Topic: syntax error

[willemjan]

I get an syntax error trying to add this code:

Code: [Select]

// Include all the output functions
require_once('fns.php');

// populate input fields into the session using a sub-array
// check http://www.scriptygoddess.com/archives/2007/05/28/how-to-use-session-cookies-in-php/
// also check the above link for remembering checkboxes values
$_SESSION['myForm'] = $_POST;
if (isset($_POST['submitted']) && ('true' == $_POST['submitted'])) {
// checks if the form is submitted and then processes it
    process_form();

} else {
// else prints the form
    print_form();
}

Why is that?

[grafitus]

Do you get line number of the error?

[willemjan]

Nope, just an syntax error. The preview shows fine!

Got an idea?

[AngelinaBelle]

That's always frustrating.
Try again, starting with a blank block, and adding only one line at a time.
 
You might also like to fiddle with the setting "Disable PHP validation" (http://simpleportal.net/index.php?action=docs;area=general_settings). It might help you get a better error message.
 
I can't see your syntax error, but that doesn't mean anything.  I would bet it has trouble including the file.
You may need to give it a directory.  See how this is done in SSI.php, and in may files in the Sources directory.

[willemjan]

Well thats odd.. By disabeling the validation, it does work. It even functions the way it should!

There is an strange error in the log BTW. It is produced by the page... Maybe that will help us to get an hold of where the syntax error comes from:

Code: [Select]

8: Use of undefined constant ’PHP_SELF’ - assumed '’PHP_SELF’'

[AngelinaBelle]

That's a clue to search the web for information about php_self.
http://php.net/manual/en/reserved.variables.php#48860
 
PHP_SELF is not a standard php constant.
Your problem is in the block or page containing PHP_SELF.
 
 

[willemjan]

I found that piece in the page that gets included:

Code: [Select]

<form method="post" action="<?php echo $_SERVER[’PHP_SELF’];?>" id="uploadform" enctype="multipart/form-data">

Are those ’ codes right? I've never seen them before in any php code. It could be that there has been an conversion problem...

[grafitus]

"’" should be "'" (an apostrophe).

[willemjan]

I tried changing it. I tried ' and ", but both don't work... After I canged it, the whole function doesn't work anymore. Very odd...

I guess the simpleportal pages don't support PHP_SELF?

[AngelinaBelle]

This is not a SimplePortal issue. This is a server issue.
Your server may not support PHP_SELF. I don't know, but you can check.
 

Code: (find) [Select]

<form method="post" action="<?php echo $_SERVER[’PHP_SELF’];?>" id="uploadform" enctype="multipart/form-data">

Code: (replace) [Select]

<form method="post" action="<?php echo $_SERVER['PHP_SELF'];?>" id="uploadform" enctype="multipart/form-data">
 
Use the php_version and php_info commands to find out what your server does support.
 

That's a clue to search the web for information about php_self.
http://php.net/manual/en/reserved.variables.php#48860
 
PHP_SELF is not a standard php constant.
Your problem is in the block or page containing PHP_SELF.

 

[willemjan]

by using the PHP info command:

_SERVER["PHP_SELF"] /info.php

Wich means the command itself does work.

No it's not an simpleportal question. Thats why I added it in custom coding

After pushing the submit button I get redirected to index.php, instead of the page it should load.

[AngelinaBelle]

In your custom php block, add this line of php

Code: [Select]

echo 'when you push the submit button, you will go to ', $SERVER['PHP_SELF'], '<br/>';


[willemjan]

This gives an empty output for the PHP_SELF function:

when you push the submit button, you will go to

Edit:

I get this in my errorlog:

8: Undefined variable: SERVER

[AngelinaBelle]

Sorry for my typo. This should be

Code: [Select]

echo 'when you push the submit button, you will go to ', $_SERVER['PHP_SELF'], '<br/>';


[willemjan]

That worked:

when you push the submit button, you will go to /index.php

Edit: I found the original code of the script I used (not modified), and there it is the same code as in this post:

I found that piece in the page that gets included:

Code: [Select]

<form method="post" action="<?php echo $_SERVER[’PHP_SELF’];?>" id="uploadform" enctype="multipart/form-data">

Are those ’ codes right? I've never seen them before in any php code. It could be that there has been an conversion problem...

[AngelinaBelle]

It should be $_Server['PHP_SELF']
 
However -- for putting it in your custom block I am not sure PHP_SELF is correct.
 
When you push the button -- it does not go to the correct place.
 
So just have a look at WHERE that URL is telling the form to go to.
 
You may wish to use one of the other URL variables.  One that gives the full and complete URL of where you wish to go when you push the button.

[willemjan]

I could do an work-around. After I press submit, I want the form to stay on the same page. I used an SP page for this. Normally you would do something like: action="your-page.php". What should I do now?

[AngelinaBelle]

Exactly. You need to tell it which page.

Code: [Select]

<form method="post" action="<?php echo $_SERVER['PHP_SELF'];?>"  id="uploadform" enctype="multipart/form-data">
the problem with PHP_SELF is it doesn't have the whole query string that defines where you actually are in SMF.
 
So what you probably want, instead of PHP_SELF, is $_SERVER['REQUEST_URL'], which SMF does its best to fix up correctly.  function cleanRequest in QueryString does this.

Code: [Select]

<form method="post" action="<?php echo $_SERVER['REQUEST_URL'];?>"  id="uploadform" enctype="multipart/form-data">


[willemjan]

Thank you very much! That did it!!