Topic: Custom Search Page help

[willerby]

My fault! Forgot to change = to LIKE

All working brilliantly. Thanks SiNAN, Thanks AngelinaBelle

Awesome support. Sorry for being a pain but I learned a lot despite not quite getting there myself.

[AngelinaBelle]

You are welcome, Willerby.
I'm learning a lot here, too, so I'm happy to pass the favor on.

[[SiNaN]]

Sorry I couldn't get to this earlier. I have been ill for the past week. I'm glad that you were able to solve it. Though I would suggest this change to escape wildcard chars:

Code: (Find) [Select]

'search' => '%' . $smcFunc['htmlspecialchars']($_POST['vsearch'], ENT_QUOTES). '%',

Code: (Replace) [Select]

'search' => '%' . strtr($smcFunc['htmlspecialchars']($_POST['vsearch'], ENT_QUOTES), array('_' => '\\_', '%' => '\\%', '*' => '%')) . '%',

[willerby]

Why SiNaN? Can you explain how it is beneficial...

Thanks - and hope you are feeling better

[AngelinaBelle]

[SiNaN] has a good point. The code he added is to protect against characters that can cause a problem to the SQL query.

[willerby]

Thanks - makes sense...

[willerby]

Members are reporting that in Internet Explorer the Search button has to be clicked, entering a search string and hitting enter just refreshes the page? I've checked this and it works fine in Firefox but not IE... any ideas?

Thanks

[[SiNaN]]

Luckily, we have such a function in SP, added for shoutbox. You can use that as well.

Code: (Find) [Select]

global $smcFunc;

Code: (Replace) [Select]

global $smcFunc, $context;

Code: (Find) [Select]

<input type="text" name="vsearch" />

Code: (Replace) [Select]

<input type="text" name="vsearch"', $context['browser']['is_ie'] ? ' onkeypress="if (sp_catch_enter(event)) { this.form.submit(); return false; }"' : '', ' />

[willerby]

Thanks SiNaN but still same result in IE... 

[[SiNaN]]

Sorry. You'll need this change as well:

Code: (Find) [Select]

   <input type="submit" name="submit" value="Search" />
</form>';

if (!empty($_POST['submit']) && !empty($_POST['vsearch']))

Code: (Replace) [Select]

   <input type="submit" name="send" value="Search" />
</form>';

if (!empty($_POST['vsearch']))

[willerby]

Thanks SiNaN - that fixed it. All working but since adding the original code this page has been throwing up an undefined error in the error log as follows:

http://www.xxx.com/forum/index.php?page=vehicle_search
8: Undefined variable: context
File: /home2/xxx/public_html/forum/Sources/Subs-Portal.php(1333) : eval()'d code
Line: 6

Line 6 is

Code: [Select]

<input type="text" name="vsearch"', $context['browser']['is_ie'] ? ' onkeypress="if (sp_catch_enter(event)) { this.form.submit(); return false; }"' : '', ' />

[AngelinaBelle]

Code: (Find) [Select]

global $smcFunc;

Code: (Replace) [Select]

global $smcFunc, $context;

That should take care of the missing $context

[willerby]

It's already in the page PHP code...

Hmmmm...

[AngelinaBelle]

That's hard to understand.  Can you attach the file?

[willerby]

This is the code cut and pasted from the SP page

Code: [Select]

global $smcFunc; $context;

echo '
<form action="" method="post">
   Enter Chassis Number or Vehicle Registration:
   <input type="text" name="vsearch"', $context['browser']['is_ie'] ? ' onkeypress="if (sp_catch_enter(event)) { this.form.submit(); return false; }"' : '', ' />
<input type="submit" name="send" value="Search" />
</form>';

if (!empty($_POST['vsearch']))
{
   $request = $smcFunc['db_query']('', '
      SELECT *
      FROM lrsoc_vehicles
      WHERE chassis_no LIKE {string:search}
         OR reg_no LIKE {string:search} ORDER BY chassis_no, year',
      array(
         'search' => '%' . strtr($smcFunc['htmlspecialchars']($_POST['vsearch'], ENT_QUOTES), array('_' => '\\_', '%' => '\\%', '*' => '%')) . '%',     )
   );
   $items = array();
   while ($row = $smcFunc['db_fetch_assoc']($request))
      $items[] = $row;
   $smcFunc['db_free_result']($request);

   if (empty($items))
   {
      echo '
<br /><strong>Sorry, there are no matches for your search!</strong>';
   }
   else
   {
      $fields = array_keys($items[0]);

      echo '
      foreach ($items as $item)
      {
         echo '
        <table><tr>';

         foreach ($item as $detail)
            echo '
      <td>', $detail, '</td>';

         echo '
   </tr>';
      }

      echo '
</table>';
   }
}

[AngelinaBelle]

How about this?

Code: [Select]

global $smcFunc; $context;
echo '<form action="" method="post">   
Enter Chassis Number or Vehicle Registration:   
<input type="text" name="vsearch"', $context['browser']['is_ie'] ? ' onkeypress="if (sp_catch_enter(event)) { this.form.submit();return false; }"' : '', ' />
<input type="submit" name="send" value="Search" /></form>';
if (!empty($_POST['vsearch']))
{
$request = $smcFunc['db_query']('', '
SELECT *
FROM lrsoc_vehicles
WHERE chassis_no LIKE {string:search}
OR reg_no LIKE {string:search}
ORDER BY chassis_no, year',
array(
'search' => '%' .
strtr($smcFunc['htmlspecialchars']($_POST['vsearch'], ENT_QUOTES), array('_' => '\\_', '%' => '\\%', '*' => '%')) .
'%',
)
);

$items = array();
while ($row = $smcFunc['db_fetch_assoc']($request))
$items[] = $row;

$smcFunc['db_free_result']($request);
if (empty($items))
{
echo '<br /><strong>Sorry, there are no matches for your search!</strong>';   
}
else
{
$fields = array_keys($items[0]);
echo '
<table>
<tr>';



foreach ($fields as $field)
echo '
<td>', $field, '</td>';

echo '
</tr>';

foreach ($items as $item)
{
echo '
        <tr>';
foreach ($item as $detail)
echo '
<td>', $detail, '</td>';
echo '
</tr>';
}

echo '
</table>';   


}
}


[[SiNaN]]

Willerby, the first line you have is this:

Code: [Select]

global $smcFunc; $context;
The semi-colon at the center should a comma.

Code: [Select]

global $smcFunc, $context;

[AngelinaBelle]

I think I'm going blind!
 
 
 

[willerby]

Thanks Angelinabelle and SiNaN. I can't believe my own stupidity.

When it says find and replace why do I think I know better and can see and edit the differences manually? Thanks for your help.

 

[AngelinaBelle]

One of these days, I'm going to have to go to a larger font size.